Upgrade extension to support rails 6 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
softr8
commented
Mar 30, 2020
softr8
commented
- New folder structure to support zeitwerk
- Follow a better decorator pattern
- Migrated permissions to follow the pattern used by Solidus
- Migrated to Circle-CI
Renamed some files and used new approach to decorate solidus code Refactored some admin views to use bootstrap
One supplier must have an admin, and one supplier belongs to a user, but that is optional
It now follows soildus pattern to define new role abilities
They were removed in this commit 869c3af but it looks like it is usefull information
There were two deface overrides for the admin products form, this caused that the supplier ids for the product were ignored and only the previous ones were sent in the request, thus the product was not updated accordingly
Remove double deface addition to admin products form
Default customer shows all stock locations and it overrides the one defined in supplier admin, this commit first tells cancan not to be able to do the default customer thing then adds the righ one
…locations Fixing cancan ability to show stock locations for supplier admins
- When an admin user creates a new product and adds a supplier and saves that product, the supplier is not being saved and the user has to establish a supplier again.
This adds the necessary spanish translations for the marketplace UI flow
Fix save suppliers with an admin role
Add translations for marketplace
Fixing issue when editing suppliers
When restocking products, suppliers should only see their variants improving the experience of managing inventory
It allows to sort by name and active, but name was the only one whitelisted
… as well Orphan data was being an issue when trying to buy a product that was used to be sold by a deleted supplier
It now handles the ase when a product can be sold by multiple suppliers and also by master store, specifically when none of the suppliers can fulfill it and only the master store
Sometimes Ckeditor module actually exists but the Assets class does not, this makes sure it is checked correctly
…lying on what the first role is
Create supplier users with role "supplier_admin"
Upgrade extension to support rails 6
There's no need to have a direct relation to users at Supplier level.
Now, we have an Admin Ability and a Staff Ability that will define the different actions. It is expected for the Admin to be able to manage everything about the supplier, while Staff members will have reduced permissions. - Refactor current supplier ability to be AdminAbility - Create base for StaffAbility - Update marketplace engine to create supplier_admin and supplier_staff roles
Update supplier admin ability to permit adding more staff members as well as adjusting permissions according specs
Adjust Staff Permissions to: - Admin Product inventory - Admin Orders - Restrict Supplier info modification - Restrict Product info modification - Restrict Pricing modification
Admins refactor
A Supplier does not have only 1 admin, it can have multiple admins, updating sample data to use this principle
move module attribute outside singleton class
The `solidus-contrib` organisation seems to have been renamed `solidusio-contrib`, so let's update the README to reflect that change.
Fix a typo in the setup instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.