fix(storage): resolve race condition in archived generation tests - #24
Open
mahendra-google wants to merge 2 commits into
Open
fix(storage): resolve race condition in archived generation tests#24mahendra-google wants to merge 2 commits into
mahendra-google wants to merge 2 commits into
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
mahendra-google
requested review from
gurusai-voleti,
salilg-eng,
shubhangi-google and
thiyaguk09
July 29, 2026 10:31
mahendra-google
marked this pull request as draft
July 31, 2026 05:16
mahendra-google
marked this pull request as ready for review
August 3, 2026 06:27
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
mahendra-google
force-pushed
the
fix/file-archived-generation-tests-flakes
branch
from
August 3, 2026 09:24
994e266 to
ad6317e
Compare
Introduce a pre-configured versioned bucket in the StorageFixture to eliminate GCS metadata propagation delays and utilized shared versioned bucket across all generation tests
mahendra-google
force-pushed
the
fix/file-archived-generation-tests-flakes
branch
from
August 3, 2026 09:53
60d383d to
7435e04
Compare
gurusai-voleti
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a fix to the issue and
resolves the test flakiness observed in the archived generation tests (such as
CopyFileArchivedGenerationTest,ListFileArchivedGenerationTestandDeleteFileArchivedGenerationTest).Previously, these tests were failing intermittently with
404 No such objector assertion errors (Expected: 2, Actual: 1).Because the tests were creating, modifying, and deleting objects immediately after enabling versioning, GCS had not always propagated the versioning state, resulting in objects being permanently deleted instead of archived.
This change removes bucket versioning toggling from generation tests and introduces
BucketNameVersioned(shared multi version bucket) in theStorageFixtureand utilized shared versioned bucket across all generation tests eliminating race conditions.