fix(storage): resolve race condition in compose object test - #25
Open
mahendra-google wants to merge 1 commit into
Open
fix(storage): resolve race condition in compose object test#25mahendra-google wants to merge 1 commit into
mahendra-google wants to merge 1 commit into
Conversation
mahendra-google
force-pushed
the
fix/compose-object-test-flake
branch
from
August 7, 2026 13:05
84fba94 to
1b74679
Compare
- Use an isolated bucket in ChangeDefaultStorageClassTest to prevent modifying the default storage class of the shared BucketNameGeneric bucket, eliminating test flakiness and mixed-storage-class compose errors in ComposeObjectTest. Fixes GoogleCloudPlatform#2038
mahendra-google
force-pushed
the
fix/compose-object-test-flake
branch
from
August 7, 2026 13:16
1b74679 to
bda43d5
Compare
mahendra-google
requested review from
gurusai-voleti,
salilg-eng,
shubhangi-google and
thiyaguk09
August 10, 2026 03:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides fix to the issue.
The flake occurred because
ChangeDefaultStorageClassTestwas changing the storage class of the shared bucketBucketNameGenerictoCOLDLINE. WhenComposeObjectTestran concurrently, it failed with aBadRequestbecause it attempted to compose objects with mixed storage classes (StandardvsColdline).This change has removed a shared bucket
BucketNameGenericused inChangeDefaultStorageClassTestto prevent modifying the default storage class of the sharedBucketNameGenericbucket, eliminatingtest flakiness and mixed-storage-class compose errors in
ComposeObjectTest