Skip to content

fix(Storage): Resolve race condition and flakiness in ListObjectsTest.ResumeWithPageToken #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mahendra-google wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(Storage): Resolve race condition and flakiness in ListObjectsTest.ResumeWithPageToken #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/ListObjectsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public void ListObjectsMatchingContextKeyValuePair()
};
var destination = new Object
{
Bucket = _fixture.ReadBucket,
Bucket = _fixture.SingleVersionBucket,
Name = IdGenerator.FromGuid(),
Contexts = new Object.ContextsData { Custom = custom }
};
Expand All @@ -146,7 +146,7 @@ public void ListObjectsMatchingContextKeyValuePair()
_fixture.Client.UploadObject(destination, source);
string filter = $@"contexts.""{contextKey}""=""{contextValue}""";
var options = new ListObjectsOptions { Filter = filter };
var objects = _fixture.Client.ListObjects(_fixture.ReadBucket, options: options).ToList();
var objects = _fixture.Client.ListObjects(_fixture.SingleVersionBucket, options: options).ToList();
var obj = Assert.Single(objects);
var fetchedContext = Assert.Single(obj.Contexts.Custom);
Assert.Equal(contextKey, fetchedContext.Key);
Expand Down
Loading