-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SearchInputDecoration
class added maintainHintHeight
#180
base: master
Are you sure you want to change the base?
Conversation
This commit refactors the `SearchInputDecoration` class in `input_decoration.dart`. It adds a new property `maintainHintHeight` and updates the constructor and methods accordingly. This change improves the flexibility and customization options for the `SearchInputDecoration` class.
Hi @mrjake34 thanks for the PR |
@mrjake34 The getter 'maintainHintHeight' isn't defined for the type 'SearchInputDecoration, I believe SearchInputDecoration is inheriting all the properties of inputDecoration |
I tested on Flutter version 3.26.0-1.0.pre.259, all tests done. There might be a newly added variable |
Perhaps you are not on flutter stable channel? Can you share the output of |
The system required the 'maintainHintHeight' attribute. I was getting an error until I included it. By adding this attribute, I was able to fix the issue. |
its channel master |
Thanks for the info, Unfortunately I won't be able to merge this PR until that property lands on the flutter stable channel, I will leave this PR open though and when this property is available, we will merge it. |
Absolutely, it can be problem, thanks for share this package to us. |
@maheshj01 sir when i close the keyboard all the suggestion showing from scratch not showing hat i have entered char in the textfield |
Can we at least merge the extension of the |
This commit refactors the
SearchInputDecoration
class ininput_decoration.dart
. It adds a new propertymaintainHintHeight
and updates the constructor and methods accordingly. This change improves the flexibility and customization options for theSearchInputDecoration
class.Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Pre-launch Checklist
///
).flutter test
If you need help, consider pinging the maintainer @maheshj01