Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SearchInputDecoration class added maintainHintHeight #180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrjake34
Copy link

@mrjake34 mrjake34 commented Oct 1, 2024

This commit refactors the SearchInputDecoration class in input_decoration.dart. It adds a new property maintainHintHeight and updates the constructor and methods accordingly. This change improves the flexibility and customization options for the SearchInputDecoration class.

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing using flutter test

If you need help, consider pinging the maintainer @maheshj01

This commit refactors the `SearchInputDecoration` class in `input_decoration.dart`. It adds a new property `maintainHintHeight` and updates the constructor and methods accordingly. This change improves the flexibility and customization options for the `SearchInputDecoration` class.
@maheshj01
Copy link
Owner

Hi @mrjake34 thanks for the PR

@maheshj01
Copy link
Owner

maheshj01 commented Oct 1, 2024

@mrjake34 The getter 'maintainHintHeight' isn't defined for the type 'SearchInputDecoration, I believe SearchInputDecoration is inheriting all the properties of inputDecoration

@mrjake34
Copy link
Author

mrjake34 commented Oct 1, 2024

I tested on Flutter version 3.26.0-1.0.pre.259, all tests done. There might be a newly added variable

@maheshj01
Copy link
Owner

maheshj01 commented Oct 1, 2024

Perhaps you are not on flutter stable channel? Can you share the output of flutter doctor?

@mrjake34
Copy link
Author

mrjake34 commented Oct 1, 2024

The system required the 'maintainHintHeight' attribute. I was getting an error until I included it. By adding this attribute, I was able to fix the issue.

@mrjake34
Copy link
Author

mrjake34 commented Oct 1, 2024

Perhaps you are not on flutter stable channel? Can you share the output of flutter doctor?

its channel master

@maheshj01
Copy link
Owner

maheshj01 commented Oct 1, 2024

Thanks for the info, Unfortunately I won't be able to merge this PR until that property lands on the flutter stable channel, I will leave this PR open though and when this property is available, we will merge it.

@mrjake34
Copy link
Author

mrjake34 commented Oct 1, 2024

Thanks for the info, Unfortunately I won't be able to merge this PR until that property lands on the flutter stable channel, I will leave this PR open though and when this version of flutter stable is available we will merge it.

Absolutely, it can be problem, thanks for share this package to us.

@sabari7320
Copy link

@maheshj01 sir when i close the keyboard all the suggestion showing from scratch not showing hat i have entered char in the textfield
https://drive.google.com/file/d/132iZYWgLzDNMllLGyOlkA15SayzkrcZe/view check this

@Gustl22
Copy link

Gustl22 commented Nov 11, 2024

Can we at least merge the extension of the copyWith constructor and ignore the value? This should be compatible with both Flutter SDKs >= and >3.24.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants