Skip to content

Node.js examples and instructions #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2025
Merged

Node.js examples and instructions #17

merged 3 commits into from
Apr 8, 2025

Conversation

b-zee
Copy link
Contributor

@b-zee b-zee commented Apr 7, 2025

  • add Node.js installation instructions
  • add Node.js examples and instructions
  • add guide

mickvandijke
mickvandijke approved these changes Apr 7, 2025
View reviewed changes
Copy link

@mickvandijke mickvandijke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nic-dorman Nic-dorman merged commit 94772b6 into maidsafe:main Apr 8, 2025
@b-zee b-zee deleted the nodejs branch April 8, 2025 08:01
@vphongph
Copy link
Contributor

vphongph commented Apr 8, 2025

Good job @b-zee! User friendly tutorial!

  • Would be nice to add https://nodejs.org/en/download for npm, node.js installation.
    They provide scripts to install them following the setup.
    As node.js and npm are related, usually people have them both already or not at all.

  • Typo in the link for 'Local Network Setup'

  • Also, we should harmonize the local network setup readme.
    Rust and Python has their own one and the general one is not as detailed (no cleanup or one liner for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickvandijke mickvandijke mickvandijke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@b-zee @vphongph @mickvandijke @Nic-dorman