chore: publish mailtrap-local to NUR via goreleaser - #47
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThe release workflow now installs Nix, uses ChangesRelease distribution
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant Nix
participant GoReleaser
participant Homebrew
participant mailtrapNur
GitHubActions->>Nix: install Nix
GitHubActions->>GoReleaser: run with GITHUB_TOKEN and GORELEASER_TOKEN
GoReleaser->>Homebrew: open version-specific package PR
GoReleaser->>mailtrapNur: open version-specific package PR
GitHubActions->>Homebrew: verify expected package PR
GitHubActions->>mailtrapNur: verify expected package PR
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6fa417d to
1d44829
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.goreleaser.yaml:
- Around line 170-171: Update the GoReleaser configuration around the NUR
pull_request setting to add a post-release verification or alert that confirms
the expected mailtrap-nur pull request was created successfully. Ensure the
release flow detects and surfaces a missing NUR PR even when GoReleaser reports
the creation error non-fatally, without changing the existing release behavior
for successful PR creation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 38186dae-7995-49d5-8464-66e7bfc0bff4
📒 Files selected for processing (3)
.github/workflows/release.yml.goreleaser.yamlREADME.md
ac80426 to
a9822dd
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yml:
- Around line 85-87: Update the NUR PR lookup in the release workflow to accept
only valid OPEN or MERGED pull requests, rather than any result from --state
all. Ensure the jq selection evaluates matching PRs for the
mailtrap-local-${version} head and does not accept a closed or unrelated PR;
preserve the existing URL output for an accepted result.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 040035be-441b-46ac-a5cd-89df752a23c5
📒 Files selected for processing (1)
.github/workflows/release.yml
a9822dd to
0de7a5d
Compare
Add a nix publisher so each tag opens a PR in mailtrap/mailtrap-nur, and fail the release job if the expected Homebrew or NUR package PR is missing (goreleaser soft-fails those errors). Co-authored-by: Cursor <cursoragent@cursor.com>
0de7a5d to
f5b297c
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
What & why
Add a
nix:publisher to goreleaser so each tag opens a PR inmailtrap/mailtrap-nur, keeping the Nix package in sync with releases the same way we already do for Homebrew.nix-hash) and pass the renamed cross-repo secretGORELEASER_TOKEN.How to test
No QA needed — non-user-facing release-pipeline and docs changes only.
Summary by CodeRabbit
New Features
nix runand profile installation options.mailtrap-sendmailcommand.Documentation