test: CI SMTP send+confirm smoke for binary and Docker - #50
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR adds a TypeScript SMTP smoke test and runs it in build, Dockerfile image, and goreleaser image CI checks. The test waits for API readiness, sends an email, and confirms the generated subject. ChangesSMTP CI coverage
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CI
participant HTTP_API
participant SMTP
participant Messages_API
CI->>HTTP_API: Poll readiness endpoint
CI->>SMTP: Send test email
CI->>Messages_API: Poll for generated subject
Messages_API-->>CI: Confirm message
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
leonid-shevtsov
force-pushed
the
test/ci-smtp-smoke
branch
from
July 30, 2026 08:47
b52646c to
4d41d42
Compare
mklocek
approved these changes
Jul 31, 2026
piobeny
approved these changes
Aug 3, 2026
Shared scripts/smoke-smtp.sh; wire into build and both docker boots so a broken SMTP ingest path fails CI. Co-authored-by: Cursor <cursoragent@cursor.com>
leonid-shevtsov
force-pushed
the
test/ci-smtp-smoke
branch
from
August 3, 2026 06:52
4d41d42 to
51ea871
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
CI was only hitting HTTP; SMTP send path untested. Add a TypeScript smoke that shells out to curl for SMTP (same as the in-app sample), then assert the message appears via the API — wired into
buildanddockerjobs.Summary by CodeRabbit
Tests
Chores