Skip to content

test: CI SMTP send+confirm smoke for binary and Docker - #50

Merged
leonid-shevtsov merged 1 commit into
mainfrom
test/ci-smtp-smoke
Aug 3, 2026
Merged

test: CI SMTP send+confirm smoke for binary and Docker#50
leonid-shevtsov merged 1 commit into
mainfrom
test/ci-smtp-smoke

Conversation

@leonid-shevtsov

@leonid-shevtsov leonid-shevtsov commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

What & why

CI was only hitting HTTP; SMTP send path untested. Add a TypeScript smoke that shells out to curl for SMTP (same as the in-app sample), then assert the message appears via the API — wired into build and docker jobs.

Summary by CodeRabbit

  • Tests

    • Added automated SMTP smoke testing to verify that messages can be sent and retrieved successfully.
    • Expanded build and Docker image checks to cover email delivery and service startup behavior.
  • Chores

    • Improved continuous integration coverage and documentation for detecting email and container-level regressions.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d15662fa-5254-4416-af8a-6b392fcc6707

📥 Commits

Reviewing files that changed from the base of the PR and between 14b77b3 and 51ea871.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • scripts/smoke-smtp.ts

📝 Walkthrough

Walkthrough

The PR adds a TypeScript SMTP smoke test and runs it in build, Dockerfile image, and goreleaser image CI checks. The test waits for API readiness, sends an email, and confirms the generated subject.

Changes

SMTP CI coverage

Layer / File(s) Summary
SMTP smoke-test flow
scripts/smoke-smtp.ts
The script validates environment variables, waits for the HTTP API, sends an SMTP message with curl, polls the messages endpoint, and reports failures.
Build and image-test integration
.github/workflows/ci.yml
The workflow runs SMTP checks against local services and both container images. The Docker job installs Node.js 22 and updates its check documentation.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CI
  participant HTTP_API
  participant SMTP
  participant Messages_API
  CI->>HTTP_API: Poll readiness endpoint
  CI->>SMTP: Send test email
  CI->>Messages_API: Poll for generated subject
  Messages_API-->>CI: Confirm message
Loading

Possibly related PRs

Suggested reviewers: sergeykorolev

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Base automatically changed from fix/docker-volume-nonroot-ownership to main August 3, 2026 06:52
Shared scripts/smoke-smtp.sh; wire into build and both docker boots
so a broken SMTP ingest path fails CI.

Co-authored-by: Cursor <cursoragent@cursor.com>
@leonid-shevtsov
leonid-shevtsov merged commit 7590702 into main Aug 3, 2026
4 of 5 checks passed
@leonid-shevtsov
leonid-shevtsov deleted the test/ci-smtp-smoke branch August 3, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants