Skip to content

Update readme for similar format to other Mailtrap SDKs - #79

Merged
DagonWat merged 3 commits into
mainfrom
update-readme-for-similar-format
Jan 13, 2026
Merged

Update readme for similar format to other Mailtrap SDKs#79
DagonWat merged 3 commits into
mainfrom
update-readme-for-similar-format

Conversation

@DagonWat

@DagonWat DagonWat commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

Motivation

  • We need to keep SDKs Readme's in same format and standard

Changes

  • Update README.md

@DagonWat
DagonWat changed the base branch from main to add-projects-api December 18, 2025 10:49
@DagonWat
DagonWat requested review from IgorDobryn and i7an December 18, 2025 10:49
Comment thread README.md
@i7an

i7an commented Dec 22, 2025

Copy link
Copy Markdown
Contributor

The PR description is probably not up to date.

@mailtrap mailtrap deleted a comment from coderabbitai Bot Dec 23, 2025
@coderabbitai

coderabbitai Bot commented Dec 26, 2025

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-readme-for-similar-format

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DagonWat
DagonWat requested a review from i7an December 26, 2025 17:30
Comment thread README.md Outdated

### Sandbox Sending

Send emails to your Sandbox inbox for testing purposes:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send emails to your Sandbox for testing purposes:

Comment thread README.md

```ruby
# config/application.rb
ActionMailer::Base.add_delivery_method :mailtrap_bulk, Mailtrap::ActionMailer::DeliveryMethod

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"So you simply removed a chunk of documentation..."

https://github.com/mailtrap/mailtrap-ruby/pull/79/files#r2640760642

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a nice catch actually, I've used wrong example for multiple clients setup, now setting correct one.

Base automatically changed from add-projects-api to main January 13, 2026 12:35
@DagonWat
DagonWat merged commit a8df70e into main Jan 13, 2026
9 checks passed
@DagonWat
DagonWat deleted the update-readme-for-similar-format branch January 13, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants