Feature/python demo poc clean#11
Merged
Merged
Conversation
mainak-debnath
commented
May 9, 2026
|
|
||
|
|
||
| def build_checkout_service() -> CheckoutService: | ||
| return CheckoutService( |
Owner
Author
There was a problem hiding this comment.
The build_checkout_service function directly instantiates concrete implementations of its dependencies (OrderRepository, PricingService, InventoryGateway, PaymentGateway). This tight coupling can make it challenging to unit test CheckoutService in isolation or to swap out implementations (e.g., for different environments or mock objects in tests). Consider making the dependencies configurable, perhaps by passing them as arguments to build_checkout_service or by using a dependency injection container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.