Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation isn't thread-safe. On multi-threaded decidim application users may find inconsistencies on the modified translations.
I was able to reproduce a race condition on the proposals index view. Modifying the translation of
decidim.proposals.application_helper.filter_state_values.evaluating
and using a scraper inspecting the label text with 4 threads and 100 requests per thread.Related to
#107
Testing
Additional information
I tested with different environments :
I am not sure the current PR is fully thread-safe but I notice a reduction of inconsistencies.
I can share the application used with different configuration, and also the scraper used if wanted