Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use typeface name in page title #172

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use typeface name in page title #172

wants to merge 4 commits into from

Conversation

mxmason
Copy link

@mxmason mxmason commented May 10, 2023 •
edited
Loading

Summary

This PR:

  • turns the name of the app from a slug into a proper title (google-webfonts-helper --> Google Webfonts Helper)
  • the name of the selected typeface to the page title after the font data has been fetched. For example, the path /fonts/abel now yields a page titled Abel | Google Webfonts Helper.

Screenshots

Before After
CleanShot 2023-05-09 at 20 46 20@2x CleanShot 2023-05-09 at 20 47 36@2x

Related issues

Closes #169

@mxmason mxmason marked this pull request as ready for review May 10, 2023 03:55
@majodev
Copy link
Owner

majodev commented May 13, 2023

Hi there, thanks for the PR.

| as separator is fine, however I would like to keep the original slug google-webfonts-helper (and the lowercased title without any dashes google webfonts helper). A dynamic title like Abel | google webfonts helper would be fine.

@majodev
Copy link
Owner

majodev commented May 13, 2023

Bug: Navigating back to the root page does not clear out dynamically set font title.

Bildschirmfoto 2023-05-13 um 08 18 29 Bildschirmfoto 2023-05-13 um 08 18 39

@majodev majodev self-requested a review May 13, 2023 06:21
majodev
majodev requested changes May 13, 2023
View reviewed changes
Copy link
Owner

@majodev majodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert back to original title + fix navigate back to root page clear dynamically generated font title.

@mxmason
Copy link
Author

mxmason commented May 13, 2023

Got it. I’ll work on this, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majodev majodev majodev requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add font name in title tag
2 participants
@mxmason @majodev