-
Notifications
You must be signed in to change notification settings - Fork 5.9k
fix(api): fix QuerySet attribute access and task execution in project invitations #9875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prakharsingh-74
wants to merge
2
commits into
makeplane:preview
Choose a base branch
from
prakharsingh-74:fix/project-invitation-crash
base: preview
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+114
−13
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 changes: 86 additions & 0 deletions
86
apps/api/plane/tests/contract/app/test_project_invitations.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| # Copyright (c) 2023-present Plane Software, Inc. and contributors | ||
| # SPDX-License-Identifier: AGPL-3.0-only | ||
| # See the LICENSE file for details. | ||
|
|
||
| from unittest.mock import patch | ||
| import pytest | ||
| from rest_framework import status | ||
|
|
||
| from plane.db.models import ( | ||
| Project, | ||
| ProjectMember, | ||
| ProjectMemberInvite, | ||
| WorkspaceMember, | ||
| ) | ||
|
|
||
|
|
||
| @pytest.mark.contract | ||
| class TestProjectInvitationsAPI: | ||
|
|
||
| @pytest.mark.django_db | ||
| @patch("plane.app.views.project.invite.project_invitation.delay") | ||
| def test_create_project_invitation_success(self, mock_delay, session_client, workspace, create_user): | ||
| """Test inviting a user to a project creates ProjectMemberInvite and triggers task.""" | ||
| project = Project.objects.create(name="Invite Test Project", identifier="ITP", workspace=workspace) | ||
| ProjectMember.objects.create(project=project, member=create_user, role=20, is_active=True) | ||
|
|
||
| url = f"/api/workspaces/{workspace.slug}/projects/{project.id}/invitations/" | ||
| data = { | ||
| "emails": [ | ||
| {"email": "newuser@example.com", "role": 15} | ||
| ] | ||
| } | ||
|
|
||
| response = session_client.post(url, data, format="json") | ||
|
|
||
| assert response.status_code == status.HTTP_200_OK | ||
| assert response.json()["message"] == "Email sent successfully" | ||
|
|
||
| # Verify ProjectMemberInvite DB record | ||
| invites = ProjectMemberInvite.objects.filter(project=project, email="newuser@example.com") | ||
| assert invites.count() == 1 | ||
| invite = invites.first() | ||
| assert invite.role == 15 | ||
|
|
||
| # Verify Celery delay was called | ||
| mock_delay.assert_called_once() | ||
| args, _ = mock_delay.call_args | ||
| assert args[0] == "newuser@example.com" | ||
| assert str(args[1]) == str(project.id) | ||
|
|
||
| @pytest.mark.django_db | ||
| def test_create_project_invitation_empty_emails(self, session_client, workspace, create_user): | ||
| """Test sending empty emails array returns 400 Bad Request.""" | ||
| project = Project.objects.create(name="Invite Test Project 2", identifier="ITP2", workspace=workspace) | ||
| ProjectMember.objects.create(project=project, member=create_user, role=20, is_active=True) | ||
|
|
||
| url = f"/api/workspaces/{workspace.slug}/projects/{project.id}/invitations/" | ||
| response = session_client.post(url, {"emails": []}, format="json") | ||
|
|
||
| assert response.status_code == status.HTTP_400_BAD_REQUEST | ||
| assert response.json()["error"] == "Emails are required" | ||
|
|
||
| @pytest.mark.django_db | ||
| def test_create_project_invitation_mixed_case_role_validation(self, session_client, workspace, create_user): | ||
| """Test that mixed-case email lookup matches existing member and enforces role check.""" | ||
| from plane.db.models import User | ||
| existing_member_user = User.objects.create_user(email="guest@example.com", username="guestmember") | ||
| # Add user as guest (role=5) in workspace | ||
| WorkspaceMember.objects.create(workspace=workspace, member=existing_member_user, role=5, is_active=True) | ||
|
|
||
| project = Project.objects.create(name="Invite Test Project 3", identifier="ITP3", workspace=workspace) | ||
| ProjectMember.objects.create(project=project, member=create_user, role=20, is_active=True) | ||
|
|
||
| url = f"/api/workspaces/{workspace.slug}/projects/{project.id}/invitations/" | ||
| # Attempting to invite ' Guest@Example.com ' with role 15 when workspace role is 5 | ||
| data = { | ||
| "emails": [ | ||
| {"email": " Guest@Example.com ", "role": 15} | ||
| ] | ||
| } | ||
|
|
||
| response = session_client.post(url, data, format="json") | ||
|
|
||
| assert response.status_code == status.HTTP_400_BAD_REQUEST | ||
| assert response.json()["error"] == "You cannot invite a user with different role than workspace role" | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.