Skip to content

Conversation

makspll
Copy link
Owner

@makspll makspll commented Oct 22, 2025

Summary

Addresses #485

@semanticdiff-com
Copy link

semanticdiff-com bot commented Oct 22, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/languages/bevy_mod_scripting_lua/src/bindings/script_value.rs  57% smaller
  crates/bevy_mod_scripting_bindings/src/function/script_function.rs  15% smaller

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

🐰 Bencher Report

Branchfeat/function-call-context-location
Testbedlinux-gha
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
component/access Lua📈 view plot
🚷 view threshold
3,778.50 ns
(-8.56%)Baseline: 4,132.35 ns
4,710.87 ns
(80.21%)
component/access Rhai📈 view plot
🚷 view threshold
5,691.30 ns
(-4.83%)Baseline: 5,980.39 ns
6,374.48 ns
(89.28%)
component/get Lua📈 view plot
🚷 view threshold
2,410.90 ns
(-3.51%)Baseline: 2,498.59 ns
2,830.28 ns
(85.18%)
component/get Rhai📈 view plot
🚷 view threshold
4,380.10 ns
(-2.38%)Baseline: 4,486.95 ns
4,842.42 ns
(90.45%)
conversions/Mut::from📈 view plot
🚷 view threshold
85.38 ns
(-4.88%)Baseline: 89.76 ns
107.09 ns
(79.73%)
conversions/Ref::from📈 view plot
🚷 view threshold
83.43 ns
(-5.20%)Baseline: 88.01 ns
104.50 ns
(79.84%)
conversions/ScriptValue::List📈 view plot
🚷 view threshold
381.30 ns
(+7.39%)Baseline: 355.06 ns
458.38 ns
(83.18%)
conversions/ScriptValue::Map📈 view plot
🚷 view threshold
1,019.60 ns
(-7.35%)Baseline: 1,100.45 ns
1,228.70 ns
(82.98%)
conversions/ScriptValue::Reference::from_into📈 view plot
🚷 view threshold
27.77 ns
(+2.55%)Baseline: 27.08 ns
30.56 ns
(90.88%)
conversions/Val::from_into📈 view plot
🚷 view threshold
280.58 ns
(-8.55%)Baseline: 306.81 ns
362.27 ns
(77.45%)
function/call 4 args Lua📈 view plot
🚷 view threshold
1,778.00 ns
(-5.97%)Baseline: 1,890.87 ns
2,077.40 ns
(85.59%)
function/call 4 args Rhai📈 view plot
🚷 view threshold
1,381.10 ns
(-7.60%)Baseline: 1,494.74 ns
1,637.49 ns
(84.34%)
function/call Lua📈 view plot
🚷 view threshold
296.60 ns
(+15.17%)Baseline: 257.53 ns
303.73 ns
(97.65%)
function/call Rhai📈 view plot
🚷 view threshold
407.70 ns
(-8.57%)Baseline: 445.92 ns
526.87 ns
(77.38%)
loading/empty Lua📈 view plot
🚷 view threshold
1,098,100.00 ns
(+83.68%)Baseline: 597,834.00 ns
1,841,934.58 ns
(59.62%)
loading/empty Rhai📈 view plot
🚷 view threshold
1,422,500.00 ns
(+69.32%)Baseline: 840,121.00 ns
1,905,585.64 ns
(74.65%)
math/vec mat ops Lua📈 view plot
🚷 view threshold
7,194.60 ns
(-9.96%)Baseline: 7,990.55 ns
9,334.20 ns
(77.08%)
math/vec mat ops Rhai📈 view plot
🚷 view threshold
7,091.40 ns
(+0.75%)Baseline: 7,038.84 ns
7,822.54 ns
(90.65%)
query/10 entities Lua📈 view plot
🚷 view threshold
19,674.00 ns
(-7.95%)Baseline: 21,372.40 ns
24,598.08 ns
(79.98%)
query/10 entities Rhai📈 view plot
🚷 view threshold
19,731.00 ns
(-7.01%)Baseline: 21,217.40 ns
23,232.58 ns
(84.93%)
query/100 entities Lua📈 view plot
🚷 view threshold
40,907.00 ns
(-6.15%)Baseline: 43,586.10 ns
47,452.29 ns
(86.21%)
query/100 entities Rhai📈 view plot
🚷 view threshold
32,791.00 ns
(-6.20%)Baseline: 34,959.50 ns
38,102.31 ns
(86.06%)
query/1000 entities Lua📈 view plot
🚷 view threshold
248,890.00 ns
(-12.42%)Baseline: 284,177.00 ns
330,031.72 ns
(75.41%)
query/1000 entities Rhai📈 view plot
🚷 view threshold
164,200.00 ns
(-5.81%)Baseline: 174,323.00 ns
196,645.32 ns
(83.50%)
reflection/10 Lua📈 view plot
🚷 view threshold
5,451.70 ns
(-13.18%)Baseline: 6,279.16 ns
7,117.94 ns
(76.59%)
reflection/10 Rhai📈 view plot
🚷 view threshold
14,977.00 ns
(-5.95%)Baseline: 15,924.20 ns
16,911.65 ns
(88.56%)
reflection/100 Lua📈 view plot
🚷 view threshold
46,532.00 ns
(-12.19%)Baseline: 52,990.30 ns
59,537.58 ns
(78.16%)
reflection/100 Rhai📈 view plot
🚷 view threshold
721,390.00 ns
(-8.29%)Baseline: 786,592.00 ns
855,971.29 ns
(84.28%)
resource/access Lua📈 view plot
🚷 view threshold
3,392.90 ns
(-8.05%)Baseline: 3,689.97 ns
4,207.21 ns
(80.64%)
resource/access Rhai📈 view plot
🚷 view threshold
5,225.30 ns
(-4.54%)Baseline: 5,473.75 ns
5,835.80 ns
(89.54%)
resource/get Lua📈 view plot
🚷 view threshold
1,986.70 ns
(-5.94%)Baseline: 2,112.21 ns
2,402.66 ns
(82.69%)
resource/get Rhai📈 view plot
🚷 view threshold
3,878.20 ns
(-3.09%)Baseline: 4,001.85 ns
4,336.50 ns
(89.43%)
🐰 View full continuous benchmarking report in Bencher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant