seibu/raiden2.cpp, seibu/r2dx_v33.cpp: Minor cleanups, some other Seibu Kaihatsu hardware minor cleanups #14255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix bankswitching in reset - Simplify CPU bankswitching method - Use logmacro.h for logging - Fix save state supports - Reduce preprocessor defines - Make some variables constant - Use generic gfx decode layout - Fix CPU ROM region size - Use BIT macro for single bit values - Reduce runtime tag lookups - Fix namings - Fix spacings - Fix filenames - Add notes seibu/r2dx_v33.cpp: Minor cleanups: - Split driver states per configurations - Fix save state support - Fix bankswitching in reset - Use BIT macro for single bit value - Use hexadecimal value for address value - Reduce runtime tag lookups - Add ROMREGION_ERASEFF for regions to prevent possible transparency issue - Fix spacings - Fix namings seibu/seibu_helper.cpp: Split partial_carry_sum into seibu_helper.cpp for reduce including unnecessary functions seibu/r2crypt.cpp: Allow variable ROM region and size in sprite ROM decryption functions seibu/seibuspi_m.cpp, seibu/seibuspi_v.cpp: Fix spacings seibu/legionna.cpp: Fix naming
…ch 'master' of https://github.com/mamedev/mame into raiden2_helper
cuavas
reviewed
Oct 6, 2025
There was a problem hiding this comment.
These functions should really have less generic names to avoid potential conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seibu/raiden2.cpp: Minor cleanups:
seibu/r2dx_v33.cpp: Minor cleanups:
seibu/seibu_helper.cpp: Split partial_carry_sum into seibu_helper.cpp for reduce including unnecessary functions
seibu/r2crypt.cpp: Allow variable ROM region and size in sprite ROM decryption functions
seibu/seibuspi_m.cpp, seibu/seibuspi_v.cpp: Fix spacings
seibu/legionna.cpp: Fix naming