Skip to content

Conversation

@as-tb-dev
Copy link
Contributor

@as-tb-dev as-tb-dev commented Oct 15, 2025

  • This adds layouts for Scrabble, Hangman (JPM), Coronation Street Quiz Game, Trivial Pursuit and Treasure Quest
  • The jpmimpct_state::digits_w() function has been updated to add bit mapping to make Scrabble work with the 16-segment LED. No other working game with this driver appears to invoke this function to drive LEDs.
  • Made minor updates to the Cluedo layout to correct minor lamp assignment issues, brightness issues, and to remove lamps with unknown functions

- add layouts for Scrabble, Hangman (JPM), Coronation Street Quiz Game, and Treasure Quest
- update Cluedo layout to correct minor lamp assignment and brightness issues
- remove lamps with unknown functions from the Cluedo layout
@james-wallace-ghub
Copy link
Member

In so much as I have any sway over these drivers, I am totally fine with these as they function, as well as the helper for 14 segs (this is something that would be beneficial for .lay to support natively, but that's another case for another time).

@as-tb-dev
Copy link
Contributor Author

Thanks. Another good feature for .LAY files could be to have lamps drive the ledXseg components. The 7-segment LEDs in Scrabble are driven by lamps. The manual creation of the 7-segment LED in the .LAY file (to able to use lamps) does not look as good as what using the led7seg component (using 'digits') would look like.

@as-tb-dev as-tb-dev marked this pull request as draft October 24, 2025 01:21
@as-tb-dev as-tb-dev changed the title jpmimpct: add layouts to Scrabble, Hangman, Coronation Street, and Treasure Quest - update Cluedo layout jpmimpct: add layouts to Scrabble, Hangman, Coronation Street, Trivial Pursuit, and Treasure Quest - update Cluedo layout Oct 24, 2025
@as-tb-dev
Copy link
Contributor Author

I did not realise I had uploaded trivialp.lay with my original PR submission - that layout was neither ready at the time nor linked into the updated jpmimpct.cpp. It is ready now, so I just updated it and linked it in.

@as-tb-dev as-tb-dev marked this pull request as ready for review October 24, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants