Skip to content

Add facility and exit code fields to slack notification - #76

Merged
thomashampson merged 2 commits into
mainfrom
add_extra_fields_to_slack_notification
Oct 14, 2026
Merged

thomashampson merged 2 commits into
mainfrom
add_extra_fields_to_slack_notification

Conversation

@MialLewis

@MialLewis MialLewis commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

This PR adds facility and exit code fields to the slack notification.

  • Facility, so we don't have to infer facility from the email address, this is sometimes ambiguous.
  • Exit code, I've added functionality to make this more informative.

Payload to slack api after this change:

{
  "channel": "#error-reports",
  "username": "Error Reporter",
  "text": "\nName: Mial Email: mial.lewis@stfc.ac.uk\nFacility: ISIS\nAdditional text:\ntest123\nUsing: mantidworkbench 6.16.20260929.1355.dev3 on macOS 26.7\nIssue link: \nExit code: -11 (SIGSEGV)\nStack Trace:\n",
  "icon_emoji": ":sadmantid:",
  "attachments": [
    {
      "mrkdwn_in": [
        "text"
      ],
      "text": "```Not provided```"
    }
  ]
}

To test, if you want, deploy a local test instance and check the payload yourself.

@MohamedAlmaki MohamedAlmaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomashampson
thomashampson merged commit 02672ed into main Oct 14, 2026
3 checks passed
@thomashampson
thomashampson deleted the add_extra_fields_to_slack_notification branch October 14, 2026 09:11
@github-project-automation github-project-automation Bot moved this from Waiting for Review to Done in ISIS core workstream v7.0.0 Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants