test(sandbox): comprehensive test suite for docker_sandbox module (+69 tests)

[manus-use]

Summary

Comprehensive test suite for the manus_agent.sandbox.docker_sandbox module — 69 fully-mocked tests covering the entire DockerSandbox class.

What's tested

Area	Tests	Coverage
__init__	4	Default params, custom params, name format, uniqueness
start() / _start_sync()	4	Image pull on miss, skip pull when exists, container params, async wrapper
stop() / _stop_sync()	4	Container removal, client close error handling, no-op when None, async wrapper
execute_code()	7	Python/JS/Bash routing, temp file cleanup (success + error), default timeout, not-running guard
execute_command()	5	Success, timeout message, kill fallback, kill exception suppression, None timeout
_execute_sync()	6	Normal output, None stdout/stderr/both, non-UTF-8 bytes, non-zero exit
_copy_to_container()	4	Tar creation, file contents, binary data, nested paths
_get_file_extension()	3 groups	Known languages, case-insensitive, unknown→txt fallback
_get_execution_command()	7	python/js/bash/shell/sh commands, unknown→cat fallback, case-insensitive
Lifecycle / Integration	4	Full start→stop, double-stop safety, non-zero exit propagation, UUID naming
Edge cases	4	Empty code, Unicode, docker_retry usage, label correctness, None client

Key design choices

• 100% mocked — no real Docker daemon required; tests run in CI without Docker
• Async-aware — tests verify asyncio.run() + run_in_executor patterns work correctly
• Tar archive verification — tests actually parse the generated tar to confirm file name, mode, and content
• Error resilience — verifies graceful handling of TimeoutError, client.close() failures, None outputs

Test results

1227 passed, 3 deselected, 3 warnings in 25.70s

Baseline was 1158 tests; this adds 69 new tests with 0 failures.

Overlap check

Confirmed no overlap with existing open PRs:

• test(utils): comprehensive test suite for docker_client module (+84 tests) #142 (docker_client utils tests — different module)
• test(tools): comprehensive test suite for code_execute module (+45 tests) #141 (code_execute tests)
• test(tools): comprehensive test suite for http_request truncation wrapper (+36 tests) #140 (http_request tests)
• test(cli): comprehensive test suite for manus-agent poc-search subcommand (+57 tests) #139 (poc-search CLI tests)
• test(tools): comprehensive test suite for track_vendor_response (+67 tests) #137 (track_vendor_response tests)
• test(cli): comprehensive test suite for manus-agent history subcommand (+39 tests) #132 (history CLI tests)
• tests: comprehensive CLI tests for _run_analyze, _run_remediate, _run_discover (+78 tests) #123 (analyze/remediate/discover CLI tests)
• test(cli): comprehensive test suite for manus-agent blast-radius subcommand #121 (blast-radius CLI tests)
• test(cli): comprehensive test suite for manus-agent osv subcommand + README docs #120 (osv CLI tests)
• test(tools): comprehensive test suite for submit_cves, tool_output_logger, and verify_exploit helpers #93 (submit_cves/tool_output_logger/verify_exploit tests)
• test(tools): comprehensive test suite for search_exploit_db, search_packetstorm, query_threat_intelligence_feeds, obtain_cves #90 (search_exploit_db/packetstorm/threat_feeds/obtain_cves tests)
• test(core-tools): comprehensive test suite for check_cisa_kev, get_nvd_data, get_cwe_details, get_otx_cve_details #89 (check_cisa_kev/get_nvd_data/get_cwe_details/get_otx_cve_details tests)
• test(integration): CLI integration test suite — blast-radius, exploit-complexity, epss-trend, check-kev #85 (integration CLI tests)

None of these test sandbox/docker_sandbox.py.