Adding RouteNamer interface #324
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks, LGTM but before we merge we should get the tests back to be running. I will look into this, merge it in and then you can rebase on master. |
Member
|
Ok, fixed the build problems in PR #325 What you could also do is add a small test to check that this functionality works so that we can guarantee that nothing breaks it in the future. Then we rebase after merging my PR and can merge this. |
Member
|
@mikeschinkel ping: would you like to continue here? otherwise I can also take over and merge after adding tests |
ejdem86
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using api2go I noticed you coupled the types with the route names, and I want to have singular types and plural routes. So I added a
RouteNamerinterface. If you are willing to accept this I will be happy to update the docs too.