Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.10.0 #13404

Merged
merged 33 commits into from
Feb 13, 2025
Merged

v3.10.0 #13404

merged 33 commits into from
Feb 13, 2025

Conversation

underoot
Copy link
Member

Features and improvements ✨

  • Add support for data-driven *-use-theme properties.
  • Improve rendering of complex SVG clip paths for vector icons.

Bug fixes 🐞

  • Fix issue where the close popup button was hidden from screen readers.
  • Fix updating of schema config values of imported styles.
  • Fix line placement symbol disappearing issue during transition from globe.
  • Fix queryRenderedFeatures not working on duplicated model layers.
  • Fix in-place update for SDF image.
  • Fix LUT not being applied to in-place updated image.
  • Fix various issues with using mouseenter and mouseleave with Interactions API.
  • Fix error with interactible map elements during interaction with a map that wasn't fully loaded.
  • Fix rendering of elevated and non-elevated lines on the same layer.
  • Fix pixel ratio handling for patterns with vector icons.
  • Fix positioning of vector icons with modified icon-size.
  • Fix a blank map issue after WebGL context loss.
  • Fix loss of precision for close to camera models.
  • Fix transparent models not being culled when terrain is enabled.

jtorresfabra and others added 30 commits February 13, 2025 13:17
@jtorresfabra @underoot
Fix problems with models and depth precision in ortho camera (interna…
9f9249b 
…l-2152)

This PR fixes two problems with ortho projection, one when models are close to the camera and the precision was being lost, and the other when using transparent models being culled, (mostly visible with terrain enabled).
@dependabot @underoot
Bump @types/node from 22.10.10 to 22.13.0 (internal-2156)
7a95c14 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.10.10 to 22.13.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @underoot
Bump the eslint-dependencies group with 3 updates (internal-2155)
e6b00bf 
Bumps the eslint-dependencies group with 3 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin), [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) and [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint).


Updates `@typescript-eslint/eslint-plugin` from 8.22.0 to 8.23.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.23.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 8.22.0 to 8.23.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.23.0/packages/parser)

Updates `typescript-eslint` from 8.22.0 to 8.23.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.23.0/packages/typescript-eslint)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: eslint-dependencies
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: eslint-dependencies
- dependency-name: typescript-eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: eslint-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @underoot
Bump playwright from 1.50.0 to 1.50.1 (internal-2157)
9dd8e95 
Bumps [playwright](https://github.com/microsoft/playwright) from 1.50.0 to 1.50.1.
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.50.0...v1.50.1)

---
updated-dependencies:
- dependency-name: playwright
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ibesora @underoot
Increase browser-tools 1.5.1 (internal-2163)
ddecc64
@woodroof @underoot
Render tests for background layer image update (internal-2162)
3f91fec
@woodroof @underoot
Render test for fill pattern inplace image update (internal-2164)
b2f1bef
@ibesora @underoot
Set config if import has default values
0c633bb
@ibesora @underoot
Get default config values from schema
9420aa4
@ibesora @underoot
Add style import test
b52c4f3
@ibesora @underoot
Update fragment schema
901875e
@speps @underoot
[MAPS3D-1643] Fixes for some native model query tests (internal-2159)
112da63 
* Fix sf-landmark-meshopt-symbols-conflation and sf-landmark-symbols-conflation so the results match between JS and Native
* Fix indentation issues and where they came from (query.js update code)
@mpulkki-mapbox @underoot
Remove height bias from line shaders (internal-2169)
4e4ca36
@jtorresfabra @underoot
Avoid indicator cutout when the polygon is under the ground (internal…
68c563c 
…-2168)
@lasselammi @underoot
[MAPS3D-1661] Parse elevation data stored in tiles (internal-2147)
b8fa028 
* Parse elevation feature data

* Add unit tests for elevation feature parsing

* Add elevation feature parser

* Add Ray2D class

* Fix issue with feature parser

* Refactor elevated feature handling

* Add more unit tests

* Rename elevated_intersections.ts -> elevation_feature.ts

* Add elevation_constants.ts

* Change the way lazy loading works for elevation data

* Small fixes

* Update MARKUP_ELEVATION_BIAS based on gl-native changes

* Simplify vertex sorting
@longpractice @underoot
fix UB for circle fragment shader (edge0 >= edge1) (internal-2166)
8b6b435
@jtorresfabra @underoot
Tweak far plane distance for ortho camera to work well with tunnels (…
dd11b61 
…internal-2171)

It also fixes an erroneus expected image from a unit test
@ibesora @underoot
Only update images that have changed
5db7a61
@dependabot @underoot
Bump rollup-plugin-esbuild in the rollup-dependencies group (internal…
2e25105 
…-2175)

Bumps the rollup-dependencies group with 1 update: [rollup-plugin-esbuild](https://github.com/egoist/rollup-plugin-esbuild).


Updates `rollup-plugin-esbuild` from 6.1.1 to 6.2.0
- [Release notes](https://github.com/egoist/rollup-plugin-esbuild/releases)
- [Changelog](https://github.com/egoist/rollup-plugin-esbuild/blob/dev/.releaserc.json)
- [Commits](egoist/rollup-plugin-esbuild@v6.1.1...v6.2.0)

---
updated-dependencies:
- dependency-name: rollup-plugin-esbuild
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: rollup-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @underoot
Bump the eslint-dependencies group with 3 updates (internal-2177)
b613dc7 
Bumps the eslint-dependencies group with 3 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin), [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) and [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint).


Updates `@typescript-eslint/eslint-plugin` from 8.23.0 to 8.24.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.24.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 8.23.0 to 8.24.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.24.0/packages/parser)

Updates `typescript-eslint` from 8.23.0 to 8.24.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.24.0/packages/typescript-eslint)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: eslint-dependencies
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: eslint-dependencies
- dependency-name: typescript-eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: eslint-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @underoot
Bump @types/node from 22.13.0 to 22.13.1 (internal-2179)
b75823c 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.13.0 to 22.13.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @underoot
Bump esbuild from 0.24.2 to 0.25.0 (internal-2178)
74fb9eb 
Bumps [esbuild](https://github.com/evanw/esbuild) from 0.24.2 to 0.25.0.
- [Release notes](https://github.com/evanw/esbuild/releases)
- [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2024.md)
- [Commits](evanw/esbuild@v0.24.2...v0.25.0)

---
updated-dependencies:
- dependency-name: esbuild
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@stepankuzmin @underoot
[GLJS-1131] Handle Interaction while Style is not fully loaded (inter…
92fc1db 
…nal-2174)
@dependabot @underoot
Bump postcss from 8.5.1 to 8.5.2 (internal-2180)
340023d 
Bumps [postcss](https://github.com/postcss/postcss) from 8.5.1 to 8.5.2.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.5.1...8.5.2)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@endanke @zmiao @underoot
Fix line placement symbol disappearing issue when in zoom level 5 (in…
057c34b 
…ternal-2172)

* WIP

* WIP

* Use ifdef as PROJECTED_POS_ON_VIEWPORT may not be defined

* remove unused shader code

* Add a new render test

* Update image

* revert debug page change

* Update expectation

---------

Co-authored-by: zmiao <[email protected]>
@underoot
[GLJS-1186] Respect pixel ratio in vector icon patterns (internal-2183)
9e839ff
@woodroof @underoot
Fixed in-place updates for SDF images, fixed LUT not being applied to…
b0464c4 
… in-place updated images (internal-2185)
@mourner @underoot
Overhaul hover interactions (internal-2165)
4a8a0da 
* overhaul hover interactions (various bug fixes)

* fixup

* fixup feature state for delegated events

* fixup unit tests

* fixup TS

* properly handle hover propagation in Interactions API

* fixup tests

* fixup for Safari

* address PR feedback
@underoot
[GLJS-1185] Fix positioning of icons with icon-size (internal-2184)
6f8fafc
@zmiao @underoot
update render test (internal-2188)
19ceb05
@longpractice @underoot
Elevated circles features shader modifications. (for mapbox/mapbox-sd…
f75aa8d 
…k#2062) (internal-2161)

* circle vertex shader z-offset

* more clear guard

* fix metal shader generator that does not support the ifdef and/or

* circle vertex shader z-offset

* merge

* add new property

* update generated code

* use the correct version number

* remove the corner case consideration for now
@underoot underoot requested a review from a team as a code owner February 13, 2025 11:29
@underoot underoot merged commit 83f5361 into main Feb 13, 2025
37 checks passed
@underoot underoot deleted the underoot/v3.10.0 branch February 13, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibesora ibesora ibesora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.