-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Swift 5 #2232
Migrate to Swift 5 #2232
Conversation
The migration introduced a number of warnings:
Some of these issues can be addressed by removing |
Some of the builds are failing because Swift 5 isn’t supported in the Xcode 10.1 / iOS 9.3 toolchain. #2206 would remove this build in favor of an Xcode 11 / iOS 13 toolchain. |
Migrated to Swift 5, for now using the Swift 5.0 migrator in Xcode 10. The idea is to have as clean a slate as possible for the Objective-C obsolescence work in #2231.
Recap:
Migrate to Swift 5.1– too soon to require Xcode 11switch
exhaustiveness warningsBlocked by #2206.
/cc @mapbox/navigation-ios