add android-offline-maps project #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natiginfo
reviewed
Oct 24, 2025
There was a problem hiding this comment.
Maybe not needed as there aren't any tests?
There was a problem hiding this comment.
Seems to be still here. Maybe forgot to commit? :)
android-offline-maps/app/src/main/java/com/example/mapbox_offline/ui/theme/Theme.kt
Outdated
Show resolved
Hide resolved
android-offline-maps/app/src/main/java/com/example/mapbox_offline/ui/theme/Type.kt
Outdated
Show resolved
Hide resolved
...-offline-maps/app/src/androidTest/java/com/example/mapbox_offline/ExampleInstrumentedTest.kt
Show resolved
Hide resolved
Comment on lines
+59
to
+60
| implementation("com.mapbox.maps:android-ndk27:11.15.3") | ||
| implementation("com.mapbox.extension:maps-compose-ndk27:11.15.3") |
There was a problem hiding this comment.
let's move these to libs.versions.toml
android-offline-maps/app/src/main/java/com/example/mapbox_offline/OfflineRegionManager.kt
Show resolved
Hide resolved
android-offline-maps/app/src/main/java/com/example/mapbox_offline/OfflineRegionManager.kt
Show resolved
Hide resolved
natiginfo
reviewed
Oct 24, 2025
android-offline-maps/app/src/main/java/com/example/mapbox_offline/TileRegionDownloadView.kt
Show resolved
Hide resolved
android-offline-maps/app/src/main/java/com/example/mapbox_offline/OfflineRegionManager.kt
Show resolved
Hide resolved
android-offline-maps/app/src/main/java/com/example/mapbox_offline/TileRegionDownloadView.kt
Show resolved
Hide resolved
android-offline-maps/app/src/main/java/com/example/mapbox_offline/TileRegionDownloadView.kt
Outdated
Show resolved
Hide resolved
natiginfo
reviewed
Oct 24, 2025
android-offline-maps/app/src/main/java/com/example/mapbox_offline/MainActivity.kt
Show resolved
Hide resolved
natiginfo
reviewed
Oct 24, 2025
android-offline-maps/app/src/main/java/com/example/mapbox_offline/OfflineRegionManager.kt
Show resolved
Hide resolved
…ine/ui/theme/Theme.kt Co-authored-by: Natig Babayev <[email protected]>
…ine/ui/theme/Type.kt Co-authored-by: Natig Babayev <[email protected]>
…ine/TileRegionDownloadView.kt Co-authored-by: Natig Babayev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for the android-offline-maps tutorial project, for review by an engineer on the Maps SDK team.
Screen_recording_20251013_162939.webm