-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiles not loading outside of metadata bounds #2521
Conversation
…k if they were past their zoom level. This fix allows for over zooming.
@wipfli Does MapLibre GL JS support reading local MBTiles? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why your changes implements the behavior you say it does. Could you explain it?
MapLibre GL JS does not have offline mbtiles support. My think is that independent of the source - be it an offline mbtiles file or a zxy http endpoint - the behavior for unavailable tiles should be the same. |
|
This small code change will, when receiving an error for no tile, instead allow the previous zooms tile to show instead of showing blank. E.g. overzoom. |
This would be a pretty significant change to the tile loading behavior. Not all users will want to have this behavior in all use cases, so I think it would need to be configurable. Please create a discussion or a design proposal so we can discuss this problem first. |
That is fine. I have fixed it in my fork for my purposes. |
Fixes issue #1318 where tiles outside of metadata bounds are not loading. This fix allows over zooming so that map features that are not on higher zoom levels will still show from their lower zoom level tiles.
For example, the offline mbtiles file might include world tiles in
z1
only, but when you zoom in farther those tiles are blank unless you move to the metadata bounds. With this fix, if you zoom into an area outside of the bounds you will get over zoom fromz1
which makes for a much nicer looking map without blank tiles.