Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UBO updates from render layers to tweakers #2703

Merged
merged 22 commits into from
Sep 10, 2024

Conversation

TimSylvester
Copy link
Collaborator

@TimSylvester TimSylvester commented Aug 7, 2024

This fits better with the long-term goal of having drawable updates only done by tweakers, centralizes the UBO updates rather than having them split across two areas, and will simplify the changes needed in the layer update methods for #2719.

@TimSylvester TimSylvester self-assigned this Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.2% +25.8Ki  +0.2% +32.0Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2703-compared-to-main.txt

Copy link

github-actions bot commented Aug 7, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%  +112Ki  +0.2% +69.5Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2703-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +27% +31.7Mi  +423% +25.3Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2703-compared-to-legacy.txt

@TimSylvester TimSylvester changed the title Move UBO updates for fill drawables from render layer to tweaker Move UBO updates from render layers to tweakers Aug 9, 2024
Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide some more context?

@louwers louwers self-requested a review August 20, 2024 17:03
Copy link
Collaborator

@alexcristici alexcristici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sjg-wdw
Copy link
Collaborator

sjg-wdw commented Sep 10, 2024

Are we done on this one?

@TimSylvester TimSylvester enabled auto-merge (squash) September 10, 2024 16:39
@TimSylvester TimSylvester merged commit 29319a7 into maplibre:main Sep 10, 2024
40 of 42 checks passed
@TimSylvester TimSylvester deleted the tweaker-binders branch September 10, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants