-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Android Vulkan backend #2711
Add Android Vulkan backend #2711
Conversation
for more information, see https://pre-commit.ci
Bloaty Results (iOS) 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2711-compared-to-main.txt |
Bloaty Results 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2711-compared-to-main.txtCompared to d387090 (legacy)
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2711-compared-to-legacy.txt |
Benchmark Results ⚡
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2711-compared-to-main.txt |
for more information, see https://pre-commit.ci
…tive into vulkan-backend-android
…jocaru/maplibre-native into vulkan-backend-android
for more information, see https://pre-commit.ci
…jocaru/maplibre-native into vulkan-backend-android
.../android/MapLibreAndroid/src/vulkan/java/org/maplibre/android/maps/renderer/MapRenderer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs DRY refactoring.
I think Vulkan-specific classes should have Vulkan
in their name and GL specific classes should have GL
in the name.
.../src/vulkan/java/org/maplibre/android/maps/renderer/textureview/TextureViewRenderThread.java
Outdated
Show resolved
Hide resolved
...d/src/vulkan/java/org/maplibre/android/maps/renderer/textureview/TextureViewMapRenderer.java
Outdated
Show resolved
Hide resolved
...roid/src/vulkan/java/org/maplibre/android/maps/renderer/surfaceview/MapLibreSurfaceView.java
Outdated
Show resolved
Hide resolved
...roid/src/vulkan/java/org/maplibre/android/maps/renderer/surfaceview/MapLibreSurfaceView.java
Outdated
Show resolved
Hide resolved
@mwilsnd The rotation should be fixed. This was due to my incomplete implementation of a surface pre-rotation. Leaving it to the Android compositor for now. |
…tive into vulkan-backend-android
…tive into vulkan-backend-android
Maybe @alexcristici and @TimSylvester can have a final look over this. I think all conversations can be resolved and we can merge this. |
sourceSets
forMapRenderer
and Surface/Texture views