Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android Vulkan backend #2711

Merged
merged 36 commits into from
Sep 6, 2024

Conversation

adrian-cojocaru
Copy link
Collaborator

@adrian-cojocaru adrian-cojocaru added java Pull requests that update Java code Vulkan labels Aug 9, 2024
@adrian-cojocaru adrian-cojocaru self-assigned this Aug 9, 2024
@adrian-cojocaru adrian-cojocaru linked an issue Aug 9, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Aug 9, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2711-compared-to-main.txt

Copy link

github-actions bot commented Aug 9, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%      -8  -0.0%     -40    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2711-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +27% +31.6Mi  +422% +25.2Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2711-compared-to-legacy.txt

Copy link

github-actions bot commented Aug 9, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0091         -0.0097             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2711-compared-to-main.txt

@adrian-cojocaru adrian-cojocaru marked this pull request as ready for review August 19, 2024 12:37
Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs DRY refactoring.

I think Vulkan-specific classes should have Vulkan in their name and GL specific classes should have GL in the name.

@mwilsnd
Copy link
Collaborator

mwilsnd commented Aug 30, 2024

Screenshot_2024-08-30-16-16-59-33_761d22eebee04fe0b23bb040358a6eab
The viewport rotates clockwise 90 degrees when I run it on the inside screen of my foldable. Touch controls still function as if the map wasn't rotated though.

@sjg-wdw
Copy link
Collaborator

sjg-wdw commented Aug 30, 2024

Screenshot_2024-08-30-16-16-59-33_761d22eebee04fe0b23bb040358a6eab The viewport rotates clockwise 90 degrees when I run it on the inside screen of my foldable. Touch controls still function as if the map wasn't rotated though.

My proposal is if the user rotates on Android we just pop up a little window that says 'No' until they rotate back.

@adrian-cojocaru
Copy link
Collaborator Author

@mwilsnd The rotation should be fixed. This was due to my incomplete implementation of a surface pre-rotation. Leaving it to the Android compositor for now.

@louwers
Copy link
Collaborator

louwers commented Sep 5, 2024

Maybe @alexcristici and @TimSylvester can have a final look over this.

I think all conversations can be resolved and we can merge this.

@adrian-cojocaru adrian-cojocaru merged commit ea09bdf into maplibre:main Sep 6, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code Vulkan
Projects
Status: Done
6 participants