[opengl-2][node] Release node-v5.4.1-pre.1 #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8e62402.
louwers
approved these changes
Aug 27, 2024
|
@louwers do you know if that required test not running is because I moved the node macos test to macos-13 instead of macos-12? From the name it looks like a node test. |
|
@acalcutt Removed the requirement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pre release is mainly to test that the publish changes in this opengl-2 branch work as expected after #2604 and #2764. After this works I plan to create a v5.4.1 final release.
Note that after the v5.4.1 final release I will try to move to main for future releases.