Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add array support for icon-padding #2845

Merged
merged 24 commits into from
Sep 21, 2024

Conversation

random3940
Copy link
Contributor

Port feature from MapLibre/JS to restore parity and close #2368. Implementation follows same idea as original PR by adding new Padding type to MapLibre/Native DSL implementation.

Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

Copy link

github-actions bot commented Sep 17, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.5% +69.7Ki  +0.5% +64.0Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2845-compared-to-main.txt

@random3940 random3940 marked this pull request as ready for review September 19, 2024 03:16
@louwers
Copy link
Collaborator

louwers commented Sep 19, 2024

Error: Failed to find metric expectations for: metrics/integration/render-tests/icon-padding/default/style.json

Error: Failed to find metric expectations for: metrics/integration/render-tests/icon-padding/databind/style.json

I can add some expectations.

Copy link

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.5%  +732Ki  +0.4%  +124Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2845-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +28% +32.5Mi  +426% +25.4Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2845-compared-to-legacy.txt

Copy link

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0019         -0.0018             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2845-compared-to-main.txt

@louwers louwers merged commit 9d553c2 into maplibre:main Sep 21, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept CSS style padding different on different sides for icon-padding property
2 participants