Add custom tile schema to the TileJSON of cog #1676

sharkAndshark · 2025-02-02T15:40:46Z

No description provided.

CommanderStorm · 2025-02-04T14:41:54Z

martin/src/cog/mod.rs

+
+        // Add COG-specific metadata to tilejson.other
+        let mut cog_info = serde_json::Map::new();
+        // Add extent bounds


FYI: tilejson has the bounds parameter which looks extremely similar.. Would this be more appropriate?

Hi @CommanderStorm ^^
The purpose for this PR is that COG could has tile schema totally different with 3857. And even it's 3857 compatible the user still need to set a custom tile schema (same with 3857) to load it if without the support from #1637
So I plan to add a custom_tile_schema(a better name required, let's discuss) to tileJSON.

The field .bounds woulbe be filled or not in this PR?

Depends on whether the SRS of the COG file could be easily transform to 4326 as per the spec of tilejson it must be represented in WGS 84. I would only fill this field if it's 4326 already or 3857. It's the simplest case.

If it's not 4326/3857, bounds would be left default(-180, -85.05112877980659, 180, 85.0511287798066)

If it's 4326/3857, bounds would be filled

The external extent field should be named .custom_tile_schema.bounds or.custom_tile_schema.extent?

It's a good question. Let's discuss. ^^

If it is in a differen projection, lets not use the bounds name.
Some rendering engines might use the field to not request tiles ^^

sharkAndshark · 2025-02-04T15:40:54Z

A nested custom_tile_schema might be a little bit ugly. Another option is we could add the required fields for custom tile schema tile size extent(might reuse the bounds field , TBD) origin resolutions directly to tile json with a not nested way. But seems this could break the compatibility of tile json spec in the future I guess.

{
    minzoom: 4,
    maxzoom: 14,
    origin: [0, 0],
    resolutions: [ 1.1, 2.2, 3.3, ....],
    tilesize: 256,
    ...
}

sharkAndshark · 2025-02-04T15:47:43Z

Make services google compatible if it's google compatible. We should do this I guess. I will finish it there
Add custom tile schema fields nested.
Add custom tile schema fields flat.

The nested

{
    ...,
    custom_tile_schema:{
           extent: [],
           tilesize: 256,
           resolutions: [],
           origin: [ ],
       },
    ....
}

The flat

{
    minzoom: 4,
    maxzoom: 14,
    origin: [0, 0],
    resolutions: [ 1.1, 2.2, 3.3, ....],
    tilesize: 256,
    ...
}

flat or nested, I'm a little prefer flat now.

sharkAndshark · 2025-02-04T16:35:17Z

CC @nyurik

sharkAndshark · 2025-02-04T17:05:08Z

It's still an early draft. We could decide flat or not after all fields added.

nyurik · 2025-02-04T19:21:54Z

If we want to modify tilejson, we may need to step back for a bit and come up with a "standard-compatible" way to:

support non-web-mercator projections
support COG data type -- currently there is no official type field. We may need to establish a MIME-based type field. See also Media (MIME) type for COG opengeospatial/CloudOptimizedGeoTIFF#1
schema is already documented as either tms or xyz (default). If we need a different tile addressing schema, this is the place to do it.

sharkAndshark · 2025-02-24T02:58:34Z

I believe it's almost there but got really busy these days, would be back next week

nyurik · 2025-02-24T03:05:49Z

wow, quiet a lot of work went into this one! @sharkAndshark what did you think about my last comment?

sharkAndshark · 2025-02-24T03:46:18Z

If we want to modify tilejson, we may need to step back for a bit and come up with a "standard-compatible" way to:

support non-web-mercator projections

support COG data type -- currently there is no official type field. We may need to establish a MIME-based type field. See also Media (MIME) type for COG opengeospatial/CloudOptimizedGeoTIFF#1

schema is already documented as either tms or xyz (default). If we need a different tile addressing schema, this is the place to do it.

Schema

No new tile schema added in this PR. The y-axis for tile index is from top to down in COG.

I would say custom tile grid added instead of custom tile schema added to make the goal of this PR clear.

MIME

I was not aware of this. But seems we no worry about it? The format output tile of COG is png

TileJSON compatible

I prefer add all these fields nested in a custom_grid field to not break the compatiblity. Not sure if it's this good. How do you think? @nyurik

sharkAndshark · 2025-02-28T08:24:07Z

tests/expected/auto/rgb_u8.json

@@ -1,4 +1,28 @@
 {
+  "custom_grid": {


Actually I'm not sure shoud we added them here( It's a little bit ugly..)

Maybe add these fileds to the json of /catalog?

curl http://127.0.0.1:3000/catalog

{ "fonts": {...}, "spirtes": {...}, "tiles": {....}, "tileGrid": { "rgb_u8": {....} } }

Maybe we need to figure out a general way to support tile grid not 3857 in Martin.

sharkAndshark · 2025-03-01T15:53:52Z

If it's difficult to make a decision about where to place these fields maybe it's not bad to make a CLI to output them(or just print them in console log). The compatibility would be greatly honored.

And maybe discuss more about support for tile grid not Web Mercator in another issue. It could be related this PR I guess.

nyurik

I keep thinking how we can stabilize the custom grid thing - perhaps collaborate with the OpenLayers on how to parametrize it? You already have most of the needed values there I think

nyurik · 2025-03-04T21:11:10Z

docs/src/sources-cog-files.md

+  layers: [
+    new TileLayer({
+      source: new XYZ({
+        url: 'https://api.maptiler.com/maps/basic/{z}/{x}/{y}.png?key=vgdy5zgzM4IIqQCC6SOn',


probably shouldn't have a key here, especially since it is not related to COG

Oops. I should remove this.

for more information, see https://pre-commit.ci

update doc

sharkAndshark · 2025-03-08T03:21:45Z

I suggest to remove the doc about cog before we figure out how to support non Web Mercator tile grid and how to tell user the tile grid of cog.
As user could not display tiles correctly without these fileds, keeping this doc would be confusing.

I'm sorry for this. But definitely I would keep working. @nyurik

nyurik · 2025-03-08T03:26:32Z

Thank you so much for your hard work on this! I am sure we can figure it out - clearly not an easy thing to do right, and even harder to change once we release it. Luckly, we are not the first to tackle this problem, so should use the knowledge gained by others

sharkAndshark · 2025-03-08T03:31:09Z

Thank you so much for your hard work on this! I am sure we can figure it out - clearly not an easy thing to do right, and even harder to change once we release it. Luckly, we are not the first to tackle this problem, so should use the knowledge gained by others

Yea! Let's do it! ^^

@nyurik

To load tiles from COG the fields in #1676 is required. To make the users not confusing, I suggested to remove the doc of cog before * find generally way to support non web mercator tile grid in martin * find the way to tell user the fields in #1676 Let's see cog as a nightly feature I will keep working on this. And I've pinned the #343 , get more inspiration form other repos and talk more there! @nyurik

nyurik · 2025-03-12T05:18:36Z

BTW, #611 was trying to add non-web-mercator projection - we may want to consolidate these efforts

CommanderStorm reviewed Feb 4, 2025

View reviewed changes

sharkAndshark added 6 commits February 11, 2025 10:19

add get_origin function

010ef99

add get_model_info function

ef04f93

add model info verify

72c6e64

get resolutions in meta

4654b13

add resolutions to meta

77b72aa

add origin to meta

139337e

sharkAndshark force-pushed the cog_custom_tile_schema branch from eff7477 to 87ba239 Compare February 11, 2025 09:05

add get_extent method

887f885

sharkAndshark force-pushed the cog_custom_tile_schema branch from 87ba239 to ba222b6 Compare February 11, 2025 15:15

sharkAndshark added 3 commits February 12, 2025 15:42

get coord transformation info only once

83432bc

use reference image t o calc resolution

6f16f0a

update test

78a9a05

sharkAndshark force-pushed the cog_custom_tile_schema branch from ba222b6 to 78a9a05 Compare February 12, 2025 09:18

sharkAndshark added 11 commits February 14, 2025 10:27

fmt && clippy

05d175b

use approx in test

c9b0554

add cusom_tile_grid to tilejson

abdd59c

get the images_ifd sorted

72662e8

fix snapshot for hashmap

14be39d

fix test

03c15c0

bless

638efe0

bless

f1c7449

fmt

6490c04

add meta_to_tilejson

8b7f549

verify whether it's pixel squared

14eb880

sharkAndshark added 10 commits February 17, 2025 11:17

update test of car_get_origin

71acb2e

cleanup

d1c1269

add test for get_extent

6c7f051

verify squared pixel

6803908

Merge remote-tracking branch 'maplibre/main' into cog_custom_tile_schema

362d240

clippy

26aa1f0

update tilejson

474ede3

get resolutions sorted

6cda582

bless

ffa3fa1

bless

07a3dd6

sharkAndshark added 4 commits February 25, 2025 16:40

bless

e524ace

Merge remote-tracking branch 'maplibre/main' into cog_custom_tile_schema

79c3a60

add draft doc

4872cc4

update doc

a2018f0

sharkAndshark commented Feb 28, 2025

View reviewed changes

nyurik reviewed Mar 4, 2025

View reviewed changes

CommanderStorm and others added 2 commits March 4, 2025 23:27

Merge branch 'main' into cog_custom_tile_schema

b4a9087

[pre-commit.ci] auto fixes from pre-commit.com hooks

8a0b5a5

for more information, see https://pre-commit.ci

nyurik mentioned this pull request Mar 5, 2025

support different coordinate reference systems like EPSG:4326 #343

Open

Update sources-cog-files.md

535e2f1

update doc

sharkAndshark mentioned this pull request Mar 8, 2025

Remove cog doc #1730

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add custom tile schema to the TileJSON of cog #1676

Add custom tile schema to the TileJSON of cog #1676

sharkAndshark commented Feb 2, 2025

CommanderStorm Feb 4, 2025

sharkAndshark Feb 4, 2025 •

edited

Loading

CommanderStorm Feb 4, 2025

sharkAndshark commented Feb 4, 2025 •

edited

Loading

sharkAndshark commented Feb 4, 2025 •

edited

Loading

sharkAndshark commented Feb 4, 2025

sharkAndshark commented Feb 4, 2025 •

edited

Loading

nyurik commented Feb 4, 2025

sharkAndshark commented Feb 24, 2025 •

edited

Loading

nyurik commented Feb 24, 2025

sharkAndshark commented Feb 24, 2025 •

edited

Loading

sharkAndshark Feb 28, 2025

sharkAndshark Feb 28, 2025 •

edited

Loading

sharkAndshark Feb 28, 2025

sharkAndshark commented Mar 1, 2025 •

edited

Loading

nyurik left a comment

nyurik Mar 4, 2025

sharkAndshark Mar 5, 2025

sharkAndshark commented Mar 8, 2025

nyurik commented Mar 8, 2025

sharkAndshark commented Mar 8, 2025

nyurik commented Mar 12, 2025

Add custom tile schema to the TileJSON of cog #1676

Are you sure you want to change the base?

Add custom tile schema to the TileJSON of cog #1676

Conversation

sharkAndshark commented Feb 2, 2025

CommanderStorm Feb 4, 2025

Choose a reason for hiding this comment

sharkAndshark Feb 4, 2025 • edited Loading

Choose a reason for hiding this comment

The field .bounds woulbe be filled or not in this PR?

The external extent field should be named .custom_tile_schema.bounds or.custom_tile_schema.extent?

CommanderStorm Feb 4, 2025

Choose a reason for hiding this comment

sharkAndshark commented Feb 4, 2025 • edited Loading

sharkAndshark commented Feb 4, 2025 • edited Loading

The nested

The flat

sharkAndshark commented Feb 4, 2025

sharkAndshark commented Feb 4, 2025 • edited Loading

nyurik commented Feb 4, 2025

sharkAndshark commented Feb 24, 2025 • edited Loading

nyurik commented Feb 24, 2025

sharkAndshark commented Feb 24, 2025 • edited Loading

Schema

MIME

TileJSON compatible

sharkAndshark Feb 28, 2025

Choose a reason for hiding this comment

sharkAndshark Feb 28, 2025 • edited Loading

Choose a reason for hiding this comment

sharkAndshark Feb 28, 2025

Choose a reason for hiding this comment

sharkAndshark commented Mar 1, 2025 • edited Loading

nyurik left a comment

Choose a reason for hiding this comment

nyurik Mar 4, 2025

Choose a reason for hiding this comment

sharkAndshark Mar 5, 2025

Choose a reason for hiding this comment

sharkAndshark commented Mar 8, 2025

nyurik commented Mar 8, 2025

sharkAndshark commented Mar 8, 2025

nyurik commented Mar 12, 2025

sharkAndshark Feb 4, 2025 •

edited

Loading

The field `.bounds` woulbe be filled or not in this PR?

The external extent field should be named `.custom_tile_schema.bounds` or`.custom_tile_schema.extent`?

sharkAndshark commented Feb 4, 2025 •

edited

Loading

sharkAndshark commented Feb 4, 2025 •

edited

Loading

sharkAndshark commented Feb 4, 2025 •

edited

Loading

sharkAndshark commented Feb 24, 2025 •

edited

Loading

sharkAndshark commented Feb 24, 2025 •

edited

Loading

sharkAndshark Feb 28, 2025 •

edited

Loading

sharkAndshark commented Mar 1, 2025 •

edited

Loading