Style serving #1711
Draft
Style serving #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
added a commit
that referenced
this pull request
Mar 2, 2025
During working on #1711 I accidentally went over this method in terms of docs. Thought this might help future devs anyhow --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
nyurik
reviewed
Mar 2, 2025
CommanderStorm
added a commit
that referenced
this pull request
Mar 2, 2025
These feature gates were accidentally forgotten. I noticed them during working on #1711 Unsure if there is a better way to find them rather than just noticing them --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…me rather than incorporating the filepath Co-authored-by: Yuri Astrakhan <[email protected]>
for more information, see https://pre-commit.ci
CommanderStorm
added a commit
that referenced
this pull request
Mar 3, 2025
…ases to reduce confusion (#1714) The testcase that caused the confusion in #1711 (comment) is actually two testcases in one. Lets split it up: - one for assuring that directories get parsed corectly and - one that extensions work.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial PR-draft for style serving.
What is still TODO:
(if someone wants to review anyway.. feel free)