Reduce the amount of linting warnings, mostly by adding the missing semicolons#41
Open
tintou wants to merge 1 commit intomarcelklehr:masterfrom
Open
Reduce the amount of linting warnings, mostly by adding the missing semicolons#41tintou wants to merge 1 commit intomarcelklehr:masterfrom
tintou wants to merge 1 commit intomarcelklehr:masterfrom
Conversation
Collaborator
eddyparkinson
left a comment
eddyparkinson
left a comment
There was a problem hiding this comment.
Thanks for this. Looks correct.
Has every change been tested. The normal rule is to check every line of code has executed correctly at least once. Have you done this?
I know these are simple changes, but simple changes do go wrong. Better to check all changes now?
Author
|
Looking at the amount of lines being changed here, I can say that I tested some but I'm sure that I've not tested every single line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.