Error on unknown child node with jump to #25
+70
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,3 +6,6 @@ build | |||
| resources/php.ini | |||
| composer.lock | |||
| nbproject | |||
|
|
|||
| .idea | |||
| atlassian-ide-plugin.xml | |||
There was a problem hiding this comment.
this doesn't belong to this pull
|
hi! please make sure you only include the needed change, and that it's unit tested. please don't include any identation changes, and try to follow the style of the original code. cheers! |
|
sorry that i closed it by mistake. feel free to rebase and push force for this same pull |
Grummfy
force-pushed
the
error-on-empty-jumpTo
branch
from
b28709f
to
4f66544
Compare
Grummfy
force-pushed
the
error-on-empty-jumpTo
branch
from
4f66544
to
ae4e98a
Compare
|
here it is the cleaned one |
Grummfy
force-pushed
the
error-on-empty-jumpTo
branch
from
ae4e98a
to
6ddbc0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
On a node result I had an error, because I was not reading the docs ... so I was useing jumpAfterEval instead of execute ... but it appears that the PAGI libs let sme erreors happends, so here is the fix.