[gsoc] support open/save/copy/paste/new actions in gr-web#2
Draft
eat4toast wants to merge 13 commits intomarcnewlin:update-to-current-grc-qtfrom
Draft
[gsoc] support open/save/copy/paste/new actions in gr-web#2eat4toast wants to merge 13 commits intomarcnewlin:update-to-current-grc-qtfrom
eat4toast wants to merge 13 commits intomarcnewlin:update-to-current-grc-qtfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft pr intend to support open/save/copy/paste/new actions in gnuradio-web
those contexts are still WIP since there are some weird interactions with emscripten virtual file system API.
refer to
open and save. The logic is really straightforward:for open:
for save or save as
I failed with the directly logging to ensure whether they are called correctly to get the file path/name, which means the official
QFileDialog.getOpenFileNamedoes not work well. (Sad)for copy and paste:
Since the upstream qt_gui in gnuradio has not implemented the
copy and pastefull feature, I try to call the origin flowgraph::copy/paste related method, with the flowgraph update. But seems there lack of some block connections with the transplant of thecopy&&paste.for new:
it will new flow graph and set the newer one to central.