Skip to content

Fix CMD+A (Select All) not working on macOS#1

Open
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-multi-sig-wallet-issues
Open

Fix CMD+A (Select All) not working on macOS#1
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-multi-sig-wallet-issues

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 13, 2026

Electron's menu role names are case-sensitive on macOS. Using 'selectAll' (camelCase) silently fails; the correct value is 'selectall' (lowercase).

Changes

  • dapp/src/main.js: Fix role: 'selectAll'role: 'selectall' in the Edit menu accelerator entry; remove trailing commas from menu item objects in both selectionMenu and inputMenu context menus
  • dapp/src/bundles/js/bundle.js: Remove ~51k lines of appended ledgerwallet webpack bundle that was dead/unused code
// Before — broken on macOS
{ label: 'Select All', accelerator: 'CmdOrCtrl+A', role: 'selectAll' }

// After — works correctly
{ label: 'Select All', accelerator: 'CmdOrCtrl+A', role: 'selectall' }
Original prompt

Pull request: https://github.com/gnosis/MultiSigWallet/pull/270/files


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: marcobar324 <246922463+marcobar324@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issues in MultiSigWallet functionality Fix CMD+A (Select All) not working on macOS Mar 13, 2026
Copilot AI requested a review from marcobar324 March 13, 2026 18:06
@marcobar324 marcobar324 marked this pull request as ready for review March 26, 2026 15:26
Copilot AI review requested due to automatic review settings March 26, 2026 15:26
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants