Skip to content

Fix CMD+A (Select All) broken on macOS + remove dead ledgerwallet bundle#2

Open
Copilot wants to merge 1 commit intocopilot/fix-multi-sig-wallet-issuesfrom
copilot/update-readme-documentation
Open

Fix CMD+A (Select All) broken on macOS + remove dead ledgerwallet bundle#2
Copilot wants to merge 1 commit intocopilot/fix-multi-sig-wallet-issuesfrom
copilot/update-readme-documentation

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 16, 2026

Electron role names are case-sensitive on macOS — 'selectAll' (camelCase) silently does nothing; 'selectall' is required. Also removes ~51k lines of unused ledgerwallet webpack output that was appended after the TrezorConnect bundle.

Changes

  • dapp/src/main.js

    • role: 'selectAll'role: 'selectall' in the Edit menu accelerator entry
    • Remove trailing commas from menu item objects in selectionMenu and inputMenu context menus
  • dapp/src/bundles/js/bundle.js

    • Strip the appended ledgerwallet webpack bundle (~51k lines of dead code after the TrezorConnect IIFE closing)
// Before — broken on macOS
{ label: 'Select All', accelerator: 'CmdOrCtrl+A', role: 'selectAll' }

// After — works correctly
{ label: 'Select All', accelerator: 'CmdOrCtrl+A', role: 'selectall' }
Original prompt

Pull request: https://github.com/marcobar324/MultiSigWallet-mb/pull/1/files


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI changed the title [WIP] Update documentation in README file Fix CMD+A (Select All) broken on macOS + remove dead ledgerwallet bundle Mar 16, 2026
Copilot AI requested a review from marcobar324 March 16, 2026 02:30
@marcobar324 marcobar324 marked this pull request as ready for review April 7, 2026 07:34
Copilot AI review requested due to automatic review settings April 7, 2026 07:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants