Add error for case/when on same line in ERB tag #1112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds test cases and a custom error to handle code like:
While this is valid ERB, it poses issues for the parser, as it would mean we'd need to turn a single statement into multiple nodes.
Those same blocks can be rewritten as:
Which is unambiguous to parse, and arguably more legible.
This adds a new ERBCaseWithConditionsInTagError to detect this pattern and direct users to split into separate tags.