Skip to content

Conversation

@citizen428
Copy link
Contributor

Note: This needs #1123 merged first.

Rationale:
Since I generally work on multiple projects at the same time, I manage my development dependencies via Nix flakes in combination with nix-direnv. The Herb project specifically has quite a few dependencies that I'd rather not install globally.

I was a bit hesitant about adding that at first, but since this project already contains an Aptfile and a Brewfile I don't see a problem with adding one more file, given that it significantly lowers the barrier of entry for Nix users.



##### For Linux
#### For Linux
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While not directly related I noticed that this and the following headline included one # too many.

cc = $(llvm_path)/bin/clang
clang_format = $(llvm_path)/bin/clang-format
clang_tidy = $(llvm_path)/bin/clang-tidy
llvm_version := 21
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from #1123, so just a temporary diff.

@citizen428
Copy link
Contributor Author

@marcoroth I understand if this is maybe a tad to specific to merge (though maybe not more specific than Aptfile or Brewfile). It could also work to enable the Wiki for this project and have me document some things there. My main goal is to make contributing to Herb easier for new people, I don't really care how we achieve that.

Copy link
Owner

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm not 100% sure that the adding Nix here is improving the onboarding for people, as it is super specific and something I cannot confidently maintain.

I personally use the Brewfile for my work on macOS and the Aptfile is being used in CI to install the packages, so at least those are somewhat ensured to work.

I think I'd rather keep the Wiki disabled and update the CONTRIBUTING.md, and if really needed, we can have a dedicated page on the herb-tools.dev docs page.

@citizen428 citizen428 closed this Feb 6, 2026
@citizen428 citizen428 deleted the add-flake-nix branch February 6, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants