-
-
Notifications
You must be signed in to change notification settings - Fork 76
Add flake.nix
#1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flake.nix
#1124
Conversation
d6e3f29 to
9905509
Compare
|
|
||
|
|
||
| ##### For Linux | ||
| #### For Linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While not directly related I noticed that this and the following headline included one # too many.
| cc = $(llvm_path)/bin/clang | ||
| clang_format = $(llvm_path)/bin/clang-format | ||
| clang_tidy = $(llvm_path)/bin/clang-tidy | ||
| llvm_version := 21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is from #1123, so just a temporary diff.
d5fb547 to
9905509
Compare
|
@marcoroth I understand if this is maybe a tad to specific to merge (though maybe not more specific than |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm not 100% sure that the adding Nix here is improving the onboarding for people, as it is super specific and something I cannot confidently maintain.
I personally use the Brewfile for my work on macOS and the Aptfile is being used in CI to install the packages, so at least those are somewhat ensured to work.
I think I'd rather keep the Wiki disabled and update the CONTRIBUTING.md, and if really needed, we can have a dedicated page on the herb-tools.dev docs page.
Note: This needs #1123 merged first.
Rationale:
Since I generally work on multiple projects at the same time, I manage my development dependencies via Nix flakes in combination with nix-direnv. The Herb project specifically has quite a few dependencies that I'd rather not install globally.
I was a bit hesitant about adding that at first, but since this project already contains an
Aptfileand aBrewfileI don't see a problem with adding one more file, given that it significantly lowers the barrier of entry for Nix users.