Merged
Conversation
citizen428
commented
Feb 6, 2026
| $(cc) -c $(flags) -fPIC $< -o $@ | ||
|
|
||
| test/%.o: test/%.c templates | ||
| test/%.o: test/%.c templates prism |
Contributor
Author
There was a problem hiding this comment.
Note: I needed to add prism as a dependency of the test target, otherwise make test could not complete after a make clean due to a missing Prism header.
Document that the function exits when the filename is invalid.
7568987 to
6a5cbab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document that the function exits when the filename is invalid.
Rationale:
I was originally a bit concerned when reading
main.cthat there was noNULLcheck around this line:However,
argv[2]should never be empty due to this check:This leaves the potential problem of non-existent files, which is handled directly inside
herb_read_file. This behavior surprised me a little bit, so I thought it might be a good idea to document it with a test.