Allow Herb to be installed from source#880
Closed
andreaslillebo wants to merge 1 commit intomarcoroth:mainfrom
Closed
Allow Herb to be installed from source#880andreaslillebo wants to merge 1 commit intomarcoroth:mainfrom
andreaslillebo wants to merge 1 commit intomarcoroth:mainfrom
Conversation
Previously Herb could only be installed if there was a precompiled gem available. This changes this by vendoring Prism on compile time.
Owner
|
Hey @andreaslillebo, Prism already gets vendored with the gem that comes from RubyGems.org (see #515). We vendor Prism before we publish the gem using the Thank you for the pull request! 🙏🏼 |
marcoroth
added a commit
that referenced
this pull request
Jan 18, 2026
This pull request improves how the `herb` gem loads its native
extension, particularly for users running preview/development versions
of Ruby.
1. Detect preview Ruby versions (`RUBY_PATCHLEVEL == -1`) and skip
precompiled extensions to avoid ABI incompatibility errors like
`undefined symbol: ruby_abi_version`
2. Add helpful error messages when the native extension fails to load,
including:
* What paths were tried
* Common causes (preview Ruby, missing compilation, missing build tools)
* How to reinstall with source compilation
* Platform-specific instructions for installing C compilers
3. Remove unnecessary `rake templates` call from `extconf.rb` since
generated files are already bundled in the gem
Resolves #880
Resolves #951
Resolves #1046
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks again for all the awesome work on the Herb. It is amazing 🤩
Previously Herb could only be installed if there was a precompiled gem available.
This changes this by vendoring Prism on compile time.
Allows workaround for issues like #874