Skip to content

Fix: Use Rails::Engine for Propshaft compatibility #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mickeytgl wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Use Rails::Engine for Propshaft compatibility #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eee4b8
Fix: Use Rails::Engine for Propshaft compatibility
mickeytgl Jan 13, 2026
a9e4adf
Fix lint errors
mickeytgl Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/reactionview.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
require_relative "reactionview/template/handlers/herb"
require_relative "reactionview/template/handlers/herb/herb"

require_relative "reactionview/railtie" if defined?(Rails::Railtie)
require_relative "reactionview/engine" if defined?(Rails::Railtie)

module ReActionView
end
15 changes: 3 additions & 12 deletions lib/reactionview/railtie.rb → lib/reactionview/engine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,15 @@
# frozen_string_literal: true

module ReActionView
class Railtie < Rails::Railtie
# If you don't want to precompile ReActionView's assets (eg. because you're using propshaft),
# you can do this in an initializer:
#
# config.after_initialize do
# config.assets.precompile -= ReActionView::Railtie::PRECOMPILE_ASSETS
# end
#
class Engine < Rails::Engine
PRECOMPILE_ASSETS = %w[
reactionview-dev-tools.esm.js
reactionview-dev-tools.umd.js
].freeze

initializer "reactionview.assets" do |app|
if ReActionView.config.development? && app.config.respond_to?(:assets)
gem_root = Gem::Specification.find_by_name("reactionview").gem_dir

app.config.assets.paths << File.join(gem_root, "app", "assets", "javascripts")
# Sprockets precompilation config (for backward compatibility)
if ReActionView.config.development? && app.config.respond_to?(:assets) && app.config.assets.respond_to?(:precompile)
app.config.assets.precompile += PRECOMPILE_ASSETS
end
end
Expand Down