Skip to content

changes to abc-bank-python #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gishaj wants to merge 15 commits into
base: master
Choose a base branch
from
Open

changes to abc-bank-python #8

gishaj wants to merge 15 commits into from

Conversation

@gishaj
Copy link

@gishaj gishaj commented May 11, 2016

Some quick notes:

  • A wrapper script runTests.sh will run all the unit tests.
  • All the tests run successfully
  • some of the daily interest calculations are assuming the commit, that needs to be changed to use mocks. It has been left commented out in bank_tests.py as the mock module is available only from python 3.3 and above.

gg added 15 commits May 10, 2016 19:00
- moving objects in bank_test to setup/teardown blocks
5949055 
- add abcbank directory name to import to run nosetest from main dir
- added setup/teardown blocks using nose
234e24f
-add wrapper script that can be if needed called from jenkins for CIT
d63fff9
- drew the account class into a more OO model
65e09f9 
- changed tests to reflect it
- enable the third test case
7601627 
- correct a typo for name of the teardown function
- change to detect class name using type()
- adding tests for account transfer
8efe39c
- adding recent withdrawal clause to maxi savings
d30e75f
- adding test case for recent withdrawal from maxi account
dcde84e
- add a comment to denote change for maxi account
e81b70f
- added daily interest calculations for checking account
99f7847
- add more test cases for differential transactions
a5b2e13 
- limit sumTransactions by date as required
- fix values for different maxi account interest rates
96f4998
- add interest since last txn till today
dc9abe0
- generalize daily interest calculation and apply to savings and chec…
6e2746a 
…king
- use daily interest flow for all accounts.
eef14e9 
- all unit tests run successfully now,
  but until current date is mocked (added a comment in bank_tests.py)
  interest calculations may not match causing those tests to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gishaj