Repository navigation
Restore positive class identity assertions - #1825
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
mrousavy
force-pushed
the
mrousavy/v1-restore-identity-tests
branch
from
October 20, 2026 15:21
f336993 to
2218405
Compare
mrousavy
marked this pull request as ready for review
October 20, 2026 15:23
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the four
instanceofassertions and the registeredChildprototype assertion changed in #1808. Both the C++ and Swift fixtures now expect the public class identity. The constructor-caching tests remain enabled.This exposes five failures in the C++ fixture. The corresponding Swift cases pass.
Baseexplicitly allows multiple implementations;Childalso exposes an enforcement gap because its decorator selects a concrete Swift implementation while a separate C++ implementation still compiles.The production fixes can be reviewed on top of this test restoration. This PR changes no implementation, decorator flags, or test exclusions.
Validation: test-runner typecheck, five helper tests, and bundling passed. The full local iOS Default run built successfully and ran all 1,485 JS cases: 1,480 passed and the five restored C++ assertions failed. All 13 native runner tests passed. There are zero iOS case exclusions and no expected-failure annotations.