Skip to content

fix(ub): fixes of UBSAN reports {DO NOT MERGE YET WE NEED THIS BUGS} #3865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: stable-23.10
Choose a base branch
from
Open

fix(ub): fixes of UBSAN reports {DO NOT MERGE YET WE NEED THIS BUGS} #3865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1879c0f
fix(ub) taking operator [] on null pointer
mariadb-LeonidFedorov Nov 17, 2025
7a95520
fix(ub): uninitilized value
mariadb-LeonidFedorov Nov 18, 2025
8794ab6
suppress(diagnostics): silince overflow disgnostics
mariadb-LeonidFedorov Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dbcon/execplan/arithmeticoperator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,8 @@ inline void ArithmeticOperator::evaluate(rowgroup::Row& row, bool& isNull, Parse
}

template <typename result_t>
inline result_t ArithmeticOperator::execute(result_t op1, result_t op2, bool& isNull)
inline __attribute__((no_sanitize("signed-integer-overflow"))) result_t
ArithmeticOperator::execute(result_t op1, result_t op2, bool& isNull)
{
if (isNull)
{
Expand Down
4 changes: 2 additions & 2 deletions dbcon/execplan/selectfilter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,9 @@ class SelectFilter : public Filter
std::vector<SRCP> fCols;
SOP fOp;
SCSEP fSub;
bool fCorrelated;
bool fCorrelated = false;
std::string fData;
uint64_t fReturnedColPos; // offset in fSub->returnedColList to indicate the start of projection
uint64_t fReturnedColPos = 0; // offset in fSub->returnedColList to indicate the start of projection
std::vector<SimpleColumn*> fSimpleColumnListExtended{};
};

Expand Down
2 changes: 1 addition & 1 deletion primitives/primproc/batchprimitiveprocessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2467,7 +2467,7 @@ SBPP BatchPrimitiveProcessor::duplicate()
bpp->smallNullPointers = smallNullPointers;
bpp->joinedRG = joinedRG;
}
bpp->mSmallSideRGPtr = &bpp->smallSideRGs[0];
bpp->mSmallSideRGPtr = bpp->smallSideRGs.empty() ? nullptr : &bpp->smallSideRGs[0];

#ifdef __FreeBSD__
pthread_mutex_unlock(&bpp->objLock);
Expand Down
7 changes: 5 additions & 2 deletions utils/funcexp/funchelpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,8 @@ inline int power(int16_t a)
}

template <typename T>
inline void decimalPlaceDec(int64_t& d, T& p, int8_t& s)
inline __attribute__((no_sanitize("signed-integer-overflow"))) void decimalPlaceDec(int64_t& d, T& p,
int8_t& s)
{
// find new scale if D < s
if (d < s)
Expand Down Expand Up @@ -541,7 +542,9 @@ inline int getNumbers(const std::string& expr, int64_t* array, execplan::OpType
return index;
}

inline int getNumbers(const std::string& expr, int* array, execplan::OpType funcType)
inline __attribute__((no_sanitize("signed-integer-overflow"))) int getNumbers(const std::string& expr,
int* array,
execplan::OpType funcType)
{
int index = 0;

Expand Down