Skip to content

Document name-redefinition and setup-cell constraints#55

Merged
manzt merged 1 commit into
mainfrom
push-owtlzvwqvkpv
Jun 8, 2026
Merged

Document name-redefinition and setup-cell constraints#55
manzt merged 1 commit into
mainfrom
push-owtlzvwqvkpv

Conversation

@manzt

@manzt manzt commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Closes #47

Copilot AI review requested due to automatic review settings June 8, 2026 15:01
@manzt manzt merged commit 3c88978 into main Jun 8, 2026
1 check passed
@manzt manzt deleted the push-owtlzvwqvkpv branch June 8, 2026 15:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the marimo-pair skill documentation to reduce common notebook authoring errors, specifically around public name redefinition across cells and constraints of the setup cell.

Changes:

  • Added explicit guidance that each public name should be defined in exactly one owning cell (with a pointer to gotchas).
  • Documented setup cell constraints (must be self-contained; cannot reference names defined in other cells) and clarified how to modify an existing setup cell.
  • Expanded gotchas.md with a dedicated section on cross-cell name redefinition and updated the references list description.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
skills/marimo-pair/SKILL.md Adds an explicit “define each public name once” rule and updates the gotchas reference blurb.
skills/marimo-pair/reference/notebook-improvements.md Adds setup-cell constraints and clarifies how to handle an already-existing setup cell.
skills/marimo-pair/reference/gotchas.md Adds a new gotcha section explaining public name redefinition failures and how to resolve them.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 48 to 49
**Fix:** Use a `_` prefix on the second import (`import pandas as _pd`) or
consolidate imports into a shared cell.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add guidance to avoid shadowing variable names?

2 participants