fix: enforce max_files limit across subdirectory recursion#10189
Merged
Conversation
The max_files check only fired inside the file-add branch, so when a subdirectory's recursion reached the limit, one more top-level file was appended before the check ran, yielding max_files + 1 leaves. Moved the check to the top of the loop iteration. Adds a deterministic regression test that forces the scandir ordering which previously only flaked intermittently in CI. Fixes MO-6726.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The max_files check only fired inside the file-add branch, so when a
subdirectory's recursion reached the limit, one more top-level file was
appended before the check ran, yielding max_files + 1 leaves. Moved the
check to the top of the loop iteration.
Adds a deterministic regression test that forces the scandir ordering
which previously only flaked intermittently in CI.
Fixes MO-6726.