test: make file URL netloc wheel test drive-independent on Windows#10198
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
mscolnick
marked this pull request as ready for review
July 16, 2026 20:15
Contributor
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.15-dev26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was authored by a coding agent.
Summary
Fixes a Windows-only failure in
test_local_wheel_path_preserves_file_url_netloc:The failure was a flaw in the test, not in
_local_wheel_path. The old assertion compared the function's output against a hand-builtPath("/tmp/pkg.whl").resolve(). On Windows, a drive-less absolute path resolves against a drive letter — and the two sides picked up different drives:C:fromurl2pathname's system-drive anchoring inside the function vs.D:from the current working directory in the test's expectation.The code correctly strips a
localhostauthority and treats it as a local file. The assertion now checks that intent directly — thatfile://localhost/...resolves identically tofile:///...(empty authority) — which is drive-independent on Windows.Test plan
uv run --group test pytest tests/_cli/test_cli_export.py::test_local_wheel_path_preserves_file_url_netloc