Skip to content

test(islands): snapshot public API exports and signatures#10218

Merged
mscolnick merged 1 commit into
mainfrom
ms/island-lifecycle-followups
Jul 18, 2026
Merged

test(islands): snapshot public API exports and signatures#10218
mscolnick merged 1 commit into
mainfrom
ms/island-lifecycle-followups

Conversation

@mscolnick

Copy link
Copy Markdown
Contributor

The islands entry (main.ts) is the public host API for the retained WASM
island lifecycle (canReplaceApp/initialize/stopApp). Add a suite that:

  • snapshots the exported names + runtime arities
  • pins the exact TypeScript signatures via expectTypeOf (enforced by tsgo,
    so accidental signature drift fails typecheck)
  • covers canReplaceApp (single-app-only, side-effect-free probe), stopApp
    forwarding, and initialize (memoized bootstrap + retry on failure)

Also document the host navigation contract and single-app constraint on the
exported functions.

The islands entry (main.ts) is the public host API for the retained WASM
island lifecycle (canReplaceApp/initialize/stopApp). Add a suite that:

- snapshots the exported names + runtime arities
- pins the exact TypeScript signatures via expectTypeOf (enforced by tsgo,
  so accidental signature drift fails typecheck)
- covers canReplaceApp (single-app-only, side-effect-free probe), stopApp
  forwarding, and initialize (memoized bootstrap + retry on failure)

Also document the host navigation contract and single-app constraint on the
exported functions.
Copilot AI review requested due to automatic review settings July 17, 2026 21:39
@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Jul 17, 2026 9:41pm

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@mscolnick
mscolnick merged commit 9b79b74 into main Jul 18, 2026
30 of 31 checks passed
@mscolnick
mscolnick deleted the ms/island-lifecycle-followups branch July 18, 2026 04:48
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.15-dev33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants