fix(table): preserve null extension-array values in JSON (#10299)#10326
Draft
hsusul wants to merge 1 commit into
Draft
fix(table): preserve null extension-array values in JSON (#10299)#10326hsusul wants to merge 1 commit into
hsusul wants to merge 1 commit into
Conversation
Author
|
I have read the CLA Document and I hereby sign the CLA |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Author
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was authored by a coding agent.
📝 Summary
Closes #10299
Problem
When a pandas DataFrame column contains an extension array (such as
pint-pandas) with missing values (pd.NA,None,np.nan),PandasTableManager._to_json_strcalls_extension_column_needs_stringify(result[col])and unconditionally performsresult[col] = result[col].astype(str). This stringifies missing cells into literal text like"<NA> meter"(or"nan") instead of JSONnull.Fix
Convert valid non-missing cells in extension columns to string (
astype(str)), while using.astype(object).where(series.notna(), None)so missing entries remainNoneand serialize to JSONnullas expected.📋 Pre-Review Checklist
✅ Merge Checklist
Testing
uv run --group test pytest tests/_plugins/ui/_impl/tables/test_pandas_table.py— Passed (122 passed).uv run ruff check marimo/ tests/— Passed with 0 errors.uv run ruff format --check marimo/ tests/— Passed with 0 issues.