feat(keymap): add option to disable command mode on Escape#9907
Draft
ameenalkhaldi wants to merge 1 commit into
Draft
feat(keymap): add option to disable command mode on Escape#9907ameenalkhaldi wants to merge 1 commit into
ameenalkhaldi wants to merge 1 commit into
Conversation
Add `enter_command_mode_on_escape` config option to allow users to disable the Escape key from entering command mode in the cell editor. This is useful for users whose muscle memory expects Escape to clear hint popups rather than navigate to command mode. Closes marimo-team#7426
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 task
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was authored by a coding agent.
Summary
Adds a new
enter_command_mode_on_escapeconfiguration option to the keymap settings, allowing users to disable the Escape key from entering command mode in the cell editor.This addresses the issue where users' muscle memory expects Escape to clear hint popups (like autocomplete or signature help) rather than navigate to command mode.
Changes
enter_command_mode_on_escape: NotRequired[bool]to backendKeymapConfiginmarimo/_config/config.pyconfig-schema.tsnavigation.tsto respect the config optionUsage
Users can set this in their marimo config (e.g.,
~/.marimo.toml):Default is
true(existing behavior preserved).Test plan
pytest tests/_config/)make fe-typecheck)make py-check)make fe-codegen)Closes #7426