Fix/container gc retention#9918
Open
edwardwkrohne wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Closes #9880
Widgets created as
would never fire their set_state methods. The issue is that
stylereturnswhich drops the actual python object
item, preventing the corresponding frontend ui object from actually interacting with the backend.Now,
styleis a class that derives from a new classContainerHtml, which explicitly contains strong references to a list of children to prevent them from being garbage collected. The offending code survives aswhich uses the explicitly stored child
self._children[0]instead of a local. Similar treatment has been given toaccordion,callout,carousel,tabs, andsidebar, all of which could potentially drop their children by converting to text and losing the original.tabswas slightly different in that it was already aUIElement, which would have been incompatible with the implementation of the newContainerHtmlclass, so it was modified to explicitly store its own children.sidebarwas reparented toContainerHtmland stores its children that way._BlockWrappedwas also reparented toContainerHtml.📋 Pre-Review Checklist
✅ Merge Checklist