fix(image): use CSS styles for width/height to support percentage values#9966
Open
allin2 wants to merge 1 commit into
Open
fix(image): use CSS styles for width/height to support percentage values#9966allin2 wants to merge 1 commit into
allin2 wants to merge 1 commit into
Conversation
The ImageOutput component used HTML attributes for width/height, which only accept pixel values. This prevented percentage values like '100%' from working. Changed to use CSS styles instead of HTML attributes, which support both pixel values and percentage values. Fixes marimo-team#9810
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ImageOutput component used HTML attributes for width/height, which only accept pixel values. This prevented percentage values like '100%' from working.
Motivation
Fixes #9810
Users reported that setting
height=100%on images and videos did not work.Changes
Validation
mo.image(src, height=100)still works (converted to "100px")mo.image(src, height="100%")now works correctlymo.image(src, width="50%")now works correctlyChecklist